Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strings from variable types #30

Closed
wants to merge 8 commits into from

Conversation

kevcube
Copy link

@kevcube kevcube commented May 19, 2021

what

  • Remove quotes from variable types

why

  • Broken in terraform 0.15

@kevcube kevcube changed the title Update variables.tf Remove strings from variable types May 20, 2021
@joe-niland joe-niland added the patch A minor, backward compatible change label May 20, 2021
@joe-niland
Copy link
Sponsor Member

/test all

@kevcube
Copy link
Author

kevcube commented Jun 10, 2021

/test all

@kevcube
Copy link
Author

kevcube commented Jun 10, 2021

@joe-niland can you plz re-exec tests 😄

@joe-niland
Copy link
Sponsor Member

/test all

@kevcube
Copy link
Author

kevcube commented Jun 13, 2021

@joe-niland once more please! 😄

@joe-niland
Copy link
Sponsor Member

/test all

@kevcube
Copy link
Author

kevcube commented Jun 14, 2021

@joe-niland looks like they didn't execute

@joe-niland
Copy link
Sponsor Member

Ah sorry @kevcube, just realised this repo is out of date with respect to automation. We'll have to get that fixed.

@mergify
Copy link

mergify bot commented Jun 17, 2021

This pull request is now in conflict. Could you fix it @kevcube? 🙏

@joe-niland
Copy link
Sponsor Member

@kevcube I added the tests and other automation so please check this one again and we'll go from there.

@mergify
Copy link

mergify bot commented Jun 18, 2021

This pull request has been automatically closed by Mergify because there are no longer any changes.

@mergify mergify bot closed this Jun 18, 2021
@kevcube
Copy link
Author

kevcube commented Jun 18, 2021

😞 dang lol

@kevcube kevcube deleted the patch-1 branch June 18, 2021 05:24
@joe-niland
Copy link
Sponsor Member

@kevcube sorry about that :) the upgrade procedure we used included this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants