Add aurora serverlessv2 support #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster.aws_rds_cluster_instance.default BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster_instance.default BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster_instance.default
kevcube
reviewed
May 3, 2022
|
/test all |
Co-authored-by: Kevin Mahoney <belay.00.theorem@icloud.com>
Gowiem
reviewed
May 3, 2022
| @@ -218,7 +226,7 @@ resource "aws_rds_cluster_instance" "default" { | |||
| count = local.cluster_instance_count | |||
| identifier = var.cluster_identifier == "" ? "${module.this.id}-${count.index + 1}" : "${var.cluster_identifier}-${count.index + 1}" | |||
| cluster_identifier = coalesce(join("", aws_rds_cluster.primary.*.id), join("", aws_rds_cluster.secondary.*.id)) | |||
| instance_class = var.instance_type | |||
| instance_class = var.serverlessv2_scaling_configuration != null ? "db.serverless" : var.instance_type | |||
There was a problem hiding this comment.
Ensure enhanced monitoring for Amazon RDS instances is enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster_instance.default | ID: BC_AWS_LOGGING_28
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 10
...
+ monitoring_interval = 5
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -218,7 +226,7 @@ resource "aws_rds_cluster_instance" "default" { | |||
| count = local.cluster_instance_count | |||
| identifier = var.cluster_identifier == "" ? "${module.this.id}-${count.index + 1}" : "${var.cluster_identifier}-${count.index + 1}" | |||
| cluster_identifier = coalesce(join("", aws_rds_cluster.primary.*.id), join("", aws_rds_cluster.secondary.*.id)) | |||
| instance_class = var.instance_type | |||
| instance_class = var.serverlessv2_scaling_configuration != null ? "db.serverless" : var.instance_type | |||
There was a problem hiding this comment.
Ensure enhanced monitoring for Amazon RDS instances is enabled
Resource: module.rds_cluster.aws_rds_cluster_instance.default | ID: BC_AWS_LOGGING_28
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 10
...
+ monitoring_interval = 5
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -218,7 +226,7 @@ resource "aws_rds_cluster_instance" "default" { | |||
| count = local.cluster_instance_count | |||
| identifier = var.cluster_identifier == "" ? "${module.this.id}-${count.index + 1}" : "${var.cluster_identifier}-${count.index + 1}" | |||
| cluster_identifier = coalesce(join("", aws_rds_cluster.primary.*.id), join("", aws_rds_cluster.secondary.*.id)) | |||
| instance_class = var.instance_type | |||
| instance_class = var.serverlessv2_scaling_configuration != null ? "db.serverless" : var.instance_type | |||
There was a problem hiding this comment.
Ensure enhanced monitoring for Amazon RDS instances is enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster_instance.default | ID: BC_AWS_LOGGING_28
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 10
...
+ monitoring_interval = 5
}Description
TBA🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e9ead5e - upgrade terraform version in test
| @@ -115,6 +115,14 @@ resource "aws_rds_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "serverlessv2_scaling_configuration" { | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e9ead5e - upgrade terraform version in test
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster.aws_rds_cluster_instance.default BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster_instance.default BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_LOGGING_28 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster_instance.default BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary
Nuru
added
no-release
|
/test all |
Nuru
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
The bats test failure is due to formatting differences among Terraform versions, and inconsistency in what the actions format with vs what the actions test with. Ignoring it for now.
Marking this version as no-release so we can release it as version 1.0, per Cloud Posse migration to production semantic versioning.
|
@Nuru I'm happy that this change is merged into the upstream. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references