Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support restoring to a specific time #216

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Support restoring to a specific time #216

merged 4 commits into from
Jun 6, 2024

Conversation

ericluria
Copy link
Contributor

@ericluria ericluria commented Jun 5, 2024 •
edited

what

  • Adds restore_to_time as an attribute of the restore_to_point_in_time parameter, allowing to restore to a specific datetime rather than the latest restorable time.

why

references

questions

I noticed while making this PR that source_cluster_identifier defaults to "120m", which looks like an inadvertent copy-and-paste from another parameter. In the aws_rds_cluster resource, this parameter is required, so it doesn't make sense to have a default anyway. Would you recommend leaving this parameter as-is, or should we fix it?

edit: fixed as part of this PR

@ericluria ericluria requested review from a team as code owners June 5, 2024 15:40
@mergify mergify bot added the triage Needs triage label Jun 5, 2024
milldr
milldr reviewed Jun 6, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@milldr milldr added feature New functionality and removed triage Needs triage labels Jun 6, 2024
@milldr
Copy link
Sponsor Member

milldr commented Jun 6, 2024 •
edited by github-actions bot

These changes were released in v1.9.1.

@ericluria ericluria requested a review from milldr June 6, 2024 16:15
milldr
milldr approved these changes Jun 6, 2024
View reviewed changes
Copy link
Sponsor Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@milldr milldr merged commit 2afd7fe into cloudposse:main Jun 6, 2024
19 checks passed
@ericluria ericluria deleted the SW-5751/restore-to-point-in-time branch June 6, 2024 16:16
@ericluria ericluria mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow point in time restoration using a specific datetime
2 participants
@ericluria @milldr