Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflicting restore_to_point_in_time attributes #217

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix conflicting restore_to_point_in_time attributes #217

merged 2 commits into from
Jun 7, 2024

Conversation

ericluria
Copy link
Contributor

@ericluria ericluria commented Jun 7, 2024 •
edited
Loading

what

  • Fixes handling of use_latest_restorable_time and restore_to_time while preserving existing default values for backwards compatibility

why

references

@ericluria ericluria requested review from a team as code owners June 7, 2024 17:58
@mergify mergify bot added the triage Needs triage label Jun 7, 2024
milldr
milldr reviewed Jun 7, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@milldr milldr added bugfix Change that restores intended behavior and removed triage Needs triage labels Jun 7, 2024
@ericluria ericluria requested a review from milldr June 7, 2024 18:21
@milldr
Copy link
Sponsor Member

milldr commented Jun 7, 2024 •
edited by github-actions bot
Loading

These changes were released in v1.10.1.

@milldr milldr added the patch A minor, backward compatible change label Jun 7, 2024
milldr
milldr approved these changes Jun 7, 2024
View reviewed changes
Copy link
Sponsor Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@milldr milldr merged commit 896af79 into cloudposse:main Jun 7, 2024
69 checks passed
@ericluria ericluria deleted the SW-5751/restore-to-point-in-time-fix branch June 7, 2024 19:25
@ericluria
Copy link
Contributor Author

@milldr thanks for the review & getting this merged so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow point in time restoration using a specific datetime
2 participants
@ericluria @milldr