Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change: Fix outputs when enabled=false. Change Security Group rules from inline to resources #80

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Breaking Change: Fix outputs when enabled=false. Change Security Group rules from inline to resources #80

merged 1 commit into from
Sep 7, 2020

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Sep 7, 2020

what

  • Fix outputs when enabled=false
  • Change Security Group rules from inline to resources

why

  • Fix outputs when enabled=false: coalesce will throw error when both parameters are empty
  • Change Security Group rules from inline to resources: output the Security Group name, ID and ARN to allow adding other rules to the SG (which is not possible with the inline SG rules, and not possible to mix inline rules with resource-based rules)

related

@aknysh aknysh requested a review from a team as a code owner September 7, 2020 17:32
@aknysh aknysh self-assigned this Sep 7, 2020
@aknysh
Copy link
Member Author

aknysh commented Sep 7, 2020

/test all

@aknysh aknysh merged commit 294287a into master Sep 7, 2020
@aknysh aknysh deleted the fix-when-enabled-false branch September 7, 2020 17:46
@aknysh aknysh mentioned this pull request Sep 11, 2020
Merged
@aknysh aknysh mentioned this pull request Sep 24, 2020
Open
@osterman osterman changed the title Fix outputs when enabled=false. Change Security Group rules from inline to resources Breaking Change: Fix outputs when enabled=false. Change Security Group rules from inline to resources Sep 24, 2020
rverma-jm added a commit to jupiterops/terraform-aws-rds-cluster that referenced this pull request Dec 5, 2020
@rverma-jm @jamengual
@jwhitcraft @maximmi @Nuru @sumeetshk @osterman @mariocoski @ac-hibbert @actions-bot @karlskewes @Gowiem @aknysh @nitrocode @frimik
Cloudposse master (#4)
ff4d940 
* Adding timeout for rds cluster resources and defaulting to TF default to 120m (cloudposse#64)

Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>

* Allow setting `copy_tags_to_snapshot` variable (cloudposse#62)

Allow copy_tags_to_snapshot to be set to true via terraform.

Signed-off-by: Jon Whitcraft <jwhitcraft@mac.com>

Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>

* Bugfix timeouts (cloudposse#65)

* Adding timeout for rds cluster resources and defaulting to TF default to 120m

* Fixing bug in timeout config

Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>

* Allow creation of a cluster without creation of a database (cloudposse#66)

* fix(cloudposse#63): instance_count should be independent of autoscaling_min_capacity (cloudposse#67)

Co-authored-by: Sumeet Shukla <sumeetshukla@sshukla-Mac-BB.local>

* Migrate to ChatOps (cloudposse#70)

* feat(enable_http_endpoint): added new enable_http_endpoint option for aurora serverless engine (cloudposse#69)

* feat(enable_http_endpoint): added new option
for aurora serverless

related to: cloudposse#54 cloudposse#51

* feat(enable_http_endpoint): corrected default value
in docs

related to: cloudposse#54 cloudposse#51

* feat: reverted back README.md changes

* feat: reverted back README.md changes

* feat: generated README.md

* Allow user to pass in cluster_identifier (cloudposse#72)

* cluster_identifier: Provide ability to supply your own cluster_identifier

Change-Id: I63ee15c74e2aa632e0c1cc11fc30ff9d013af4d2

* cluster_identifier: Sort out naming for final snapshot

Change-Id: I9f3b103c81b96662f35451d973640fc4d80b8236

* Updated README.md

Co-authored-by: Andy Hibbert <anhibber@cisco.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* 73: Add auto_minor_version_upgrade flag variable (cloudposse#74)

* 73: Add auto_minor_version_upgrade flag variable

Default to true as per provider.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#auto_minor_version_upgrade

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* [AUTOMATED] Update Version Pinning for Terraform to support 0.13 (cloudposse#75)

## What

1. Update Version Pinning for Terraform to support 0.13

## Why

1. This is a relatively minor update that the CloudPosse module already likely supports.
1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.

* [AUTOMATED] Update terraform-null-label versions to support Terraform 0.13 (cloudposse#76)

* Support terraform 0.13 (cloudposse#77)

* Update to `context.tf`. Add `primary` and `secondary` cluster resources (cloudposse#79)

* Update to `context.tf`

* Update to `context.tf`

* Update to `context.tf`

* Update to `context.tf`

* Fix outputs when `enabled=false`. Change Security Group rules from inline to resources (cloudposse#80)

* Add IAM role for enhanced monitoring (cloudposse#82)

* Update examples

* Add IAM role for enhanced monitoring

* Add percona xtrabackup import from S3 (cloudposse#84)

* Update main.tf

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update main.tf

* Update main.tf

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* Fixes DNS prepending var.name to local.cluster_dns_name (cloudposse#88)

## what
* DNS was changing when it shouldn't have been, it was the value of:

```
${var.name}-${local.cluster_dns_name}
```

I think this may have changed in https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/releases/tag/0.6.0

This changes the parameter to `dns_name` and upgrades the version to get a stable DNS record

## why

* Fix broken DNS

* Serverless: Aurora 2.07.1 MySQL 5.7 and encrypted_storage parameter fix (cloudposse#91)

* Aurora serverless is encrypted by default

Follow upstream documentation and don't set `storage_encrypted` at all.

* Include Aurora 2.07.1 MySQL  5.7 example

Also fix minor missing new item in 5.6 example.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Updates.serverless_2_07_01.html

* Add suport for cluster cloning (cloudposse#92)

* Fixing incompatibility with snashot_identifier

* using upstream names instead

Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>
Co-authored-by: Jon Whitcraft <jwhitcraft@mac.com>
Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Co-authored-by: Sumeet Shukla <sumeet.k.shukla@gmail.com>
Co-authored-by: Sumeet Shukla <sumeetshukla@sshukla-Mac-BB.local>
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Mariusz Rajczakowski <mariuszrajczakowski@pm.me>
Co-authored-by: Andrew Hibbert <andrew_hibbert@hotmail.com>
Co-authored-by: Andy Hibbert <anhibber@cisco.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Co-authored-by: Karl <karl.skewes@gmail.com>
Co-authored-by: Matt Gowie <gowie.matt@gmail.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: nitro <nitrocode@users.noreply.github.com>
Co-authored-by: Mikael Fridh <frimik@gmail.com>
rverma-jm added a commit to jupiterops/terraform-aws-rds-cluster that referenced this pull request Dec 9, 2020
@rverma-jm @jamengual
@jwhitcraft @maximmi @Nuru @sumeetshk @osterman @mariocoski @ac-hibbert @actions-bot @karlskewes @Gowiem @aknysh @nitrocode @frimik
Cloudposse master (#5)
794879c 
* Adding timeout for rds cluster resources and defaulting to TF default to 120m (cloudposse#64)

Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>

* Allow setting `copy_tags_to_snapshot` variable (cloudposse#62)

Allow copy_tags_to_snapshot to be set to true via terraform.

Signed-off-by: Jon Whitcraft <jwhitcraft@mac.com>

Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>

* Bugfix timeouts (cloudposse#65)

* Adding timeout for rds cluster resources and defaulting to TF default to 120m

* Fixing bug in timeout config

Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>

* Allow creation of a cluster without creation of a database (cloudposse#66)

* fix(cloudposse#63): instance_count should be independent of autoscaling_min_capacity (cloudposse#67)

Co-authored-by: Sumeet Shukla <sumeetshukla@sshukla-Mac-BB.local>

* Migrate to ChatOps (cloudposse#70)

* feat(enable_http_endpoint): added new enable_http_endpoint option for aurora serverless engine (cloudposse#69)

* feat(enable_http_endpoint): added new option
for aurora serverless

related to: cloudposse#54 cloudposse#51

* feat(enable_http_endpoint): corrected default value
in docs

related to: cloudposse#54 cloudposse#51

* feat: reverted back README.md changes

* feat: reverted back README.md changes

* feat: generated README.md

* Allow user to pass in cluster_identifier (cloudposse#72)

* cluster_identifier: Provide ability to supply your own cluster_identifier

Change-Id: I63ee15c74e2aa632e0c1cc11fc30ff9d013af4d2

* cluster_identifier: Sort out naming for final snapshot

Change-Id: I9f3b103c81b96662f35451d973640fc4d80b8236

* Updated README.md

Co-authored-by: Andy Hibbert <anhibber@cisco.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* 73: Add auto_minor_version_upgrade flag variable (cloudposse#74)

* 73: Add auto_minor_version_upgrade flag variable

Default to true as per provider.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#auto_minor_version_upgrade

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* [AUTOMATED] Update Version Pinning for Terraform to support 0.13 (cloudposse#75)

## What

1. Update Version Pinning for Terraform to support 0.13

## Why

1. This is a relatively minor update that the CloudPosse module already likely supports.
1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.

* [AUTOMATED] Update terraform-null-label versions to support Terraform 0.13 (cloudposse#76)

* Support terraform 0.13 (cloudposse#77)

* Update to `context.tf`. Add `primary` and `secondary` cluster resources (cloudposse#79)

* Update to `context.tf`

* Update to `context.tf`

* Update to `context.tf`

* Update to `context.tf`

* Fix outputs when `enabled=false`. Change Security Group rules from inline to resources (cloudposse#80)

* Add IAM role for enhanced monitoring (cloudposse#82)

* Update examples

* Add IAM role for enhanced monitoring

* Add percona xtrabackup import from S3 (cloudposse#84)

* Update main.tf

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update variables.tf

* Updated README.md

* Update main.tf

* Update main.tf

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>

* Fixes DNS prepending var.name to local.cluster_dns_name (cloudposse#88)

## what
* DNS was changing when it shouldn't have been, it was the value of:

```
${var.name}-${local.cluster_dns_name}
```

I think this may have changed in https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/releases/tag/0.6.0

This changes the parameter to `dns_name` and upgrades the version to get a stable DNS record

## why

* Fix broken DNS

* Serverless: Aurora 2.07.1 MySQL 5.7 and encrypted_storage parameter fix (cloudposse#91)

* Aurora serverless is encrypted by default

Follow upstream documentation and don't set `storage_encrypted` at all.

* Include Aurora 2.07.1 MySQL  5.7 example

Also fix minor missing new item in 5.6 example.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Updates.serverless_2_07_01.html

* Add suport for cluster cloning (cloudposse#92)

* Fixing incompatibility with snashot_identifier

* using upstream names instead

* remove module with db_name

* remove module with db_name

* remove module with db_name

Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Co-authored-by: PePe (Jose) Amengual <jamengual@sonatype.com>
Co-authored-by: Jon Whitcraft <jwhitcraft@mac.com>
Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Co-authored-by: Sumeet Shukla <sumeet.k.shukla@gmail.com>
Co-authored-by: Sumeet Shukla <sumeetshukla@sshukla-Mac-BB.local>
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Mariusz Rajczakowski <mariuszrajczakowski@pm.me>
Co-authored-by: Andrew Hibbert <andrew_hibbert@hotmail.com>
Co-authored-by: Andy Hibbert <anhibber@cisco.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Co-authored-by: Karl <karl.skewes@gmail.com>
Co-authored-by: Matt Gowie <gowie.matt@gmail.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: nitro <nitrocode@users.noreply.github.com>
Co-authored-by: Mikael Fridh <frimik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Nuru Nuru Awaiting requested review from Nuru

@htplbc htplbc Awaiting requested review from htplbc

@danjbh danjbh Awaiting requested review from danjbh

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Inline Security Group Rules to Resources
2 participants
@aknysh @osterman