Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use for_each instead of count #3

Merged
merged 4 commits into from Sep 10, 2020
Merged

Use for_each instead of count #3

merged 4 commits into from Sep 10, 2020

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Sep 10, 2020 •
edited

what

  • Optionally use for_each instead of count when creating routes
  • Avoid setting transit_gateway_default_route_table_association and transit_gateway_default_route_table_propagation in aws_ec2_transit_gateway_vpc_attachment

why

  • Avoid unnecessary changes when making necessary ones
  • These were not previously configurable (always set to false) and configuring them is not supported when using Resource Access Manager, so setting them false caused Terraform to always plan changes to them. At least by leaving them unset/default we can avoid constant plan changes.

references

@Nuru Nuru added terraform/0.13 Module requires Terraform 0.13 or later patch A minor, backward compatible change labels Sep 10, 2020
@Nuru Nuru requested review from a team as code owners September 10, 2020 08:01
@Nuru Nuru requested review from htplbc and danjbh September 10, 2020 08:01
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Sep 10, 2020

/test all

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Sep 10, 2020

/test all

aknysh
aknysh reviewed Sep 10, 2020
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo, otherwise LGTM

@Nuru @aknysh
Fix typo
9475406 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Sep 10, 2020

/test all

@Nuru Nuru merged commit 4267b52 into master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htplbc htplbc htplbc approved these changes

@aknysh aknysh aknysh approved these changes

@danjbh danjbh Awaiting requested review from danjbh

Assignees
No one assigned
Labels
patch A minor, backward compatible change terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nuru @htplbc @aknysh