Refactor requester.tf to use aws_route_tables data source #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vquie
force-pushed
the
update-requester-route-tables
branch
from
316b624
to
b9324e6
Compare
|
/terratest |
|
Please run |
|
I've merged the baseline fixes, and don’t know the fix for the current error yet. It’s also in main branch |
Done. Thanks. |
|
I am getting this same error, can this get merged? |
vquie
force-pushed
the
update-requester-route-tables
branch
from
0804651
to
80efa84
Compare
|
@vquie thanks for the PR. |
|
Unfortunately this failed on my machine. Any ideas? |
@vquie please run https://docs.gomplate.ca/installing/ and then again: make init
make github/init
make readme |
|
@aknysh, thanks. I should've figured that out myself. 🤦 The command went through successfully and the new changes are pushed. |
hans-d
added
wip
|
/terratest |
vquie
force-pushed
the
update-requester-route-tables
branch
from
9e60837
to
5e55a1a
Compare
|
/terratest |
|
💥 This pull request now has conflicts. Could you fix it @vquie? 🙏 |
- Replaced the "aws_route_table" data source with "aws_route_tables" for better handling of multiple route tables in the VPC. - Added a filter to the "aws_route_tables" data source to only include route tables associated with the subnets in the VPC. - Updated dependencies in the "aws_route" resource to reflect the change in data source.
- Renamed `default_rts` to `accepter_default_rts` in accepter.tf and updated references - Added `requester_default_rts` in requester.tf to handle cases with more subnets than route tables - Updated `requester_aws_rt_map` to use `requester_default_rt_id` if specific route table id is not found for a subnet
- Adjusted the alignment of the variables in the locals block for better readability. - No functional changes were made. Signed-off-by: Vitali Quiering <vitali@quiering.com>
- Removed `aws_route_table.requester` data source - Renamed `aws_route_tables.default_rts` to `aws_route_tables.accepter_default_rts` - Added `aws_route_tables.requester` and `aws_route_tables.requester_default_rts` data sources Signed-off-by: Vitali Quiering <vitali@quiering.com>
- Removed redundant information and unnecessary sections - Reorganized content for better flow and readability - Updated formatting to improve visual presentation - Fixed broken links and incorrect data source references - Added a section for contributors and contribution guidelines - Updated the About section with more detailed information about Cloud Posse - Removed unnecessary sharing links and badges - Updated copyright information
- Updated the method of retrieving route table IDs in both accepter.tf and requester.tf files to use a more efficient list comprehension. - Removed unnecessary data blocks for aws_caller_identity and aws_region in requester.tf as they were not being used. Signed-off-by: Vitali Quiering <vitali@quiering.com>
- Refactor README to improve readability and update links - Remove unused data sources from terraform documentation - Update contributing guidelines and community information - Add details about commercial support and licensing - Remove unnecessary markdownlint comments
vquie
force-pushed
the
update-requester-route-tables
branch
from
5e55a1a
to
60147e7
Compare
|
💥 This pull request now has conflicts. Could you fix it @vquie? 🙏 |
|
This PR was closed due to inactivity and merge conflicts. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
All my VPCs with more then one subnet raised this error.
references
https://sweetops.slack.com/archives/CB6GHNLG0/p1694006033839549