Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor requester.tf to use aws_route_tables data source #78

Closed
wants to merge 9 commits into from
Closed

Refactor requester.tf to use aws_route_tables data source #78

wants to merge 9 commits into from

Commits on Apr 2, 2024

  1. Refactor requester.tf to use aws_route_tables data source 

    - Replaced the "aws_route_table" data source with "aws_route_tables" for better
  handling of multiple route tables in the VPC.
- Added a filter to the "aws_route_tables" data source to only include route
  tables associated with the subnets in the VPC.
- Updated dependencies in the "aws_route" resource to reflect the change in data
  source.
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5f854d8 View commit details
    Browse the repository at this point in the history

  2. Update default route tables for accepter and requester 

    - Renamed `default_rts` to `accepter_default_rts` in accepter.tf and updated references
- Added `requester_default_rts` in requester.tf to handle cases with more subnets than route tables
- Updated `requester_aws_rt_map` to use `requester_default_rt_id` if specific route table id is not found for a subnet
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6ed6c3b View commit details
    Browse the repository at this point in the history

  3. Cleaned up alignment in requester.tf 

    - Adjusted the alignment of the variables in the locals block for better readability.
- No functional changes were made.

Signed-off-by: Vitali Quiering <vitali@quiering.com>
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f14efd1 View commit details
    Browse the repository at this point in the history

  4. Update terraform.md with new data sources 

    - Removed `aws_route_table.requester` data source
- Renamed `aws_route_tables.default_rts` to `aws_route_tables.accepter_default_rts`
- Added `aws_route_tables.requester` and `aws_route_tables.requester_default_rts` data sources

Signed-off-by: Vitali Quiering <vitali@quiering.com>
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    334f4a3 View commit details
    Browse the repository at this point in the history

  5. Update requester.tf

    @max-lobur @vquie
    max-lobur authored and vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d083f89 View commit details
    Browse the repository at this point in the history

  6. linting 

    - Adjusted the alignment of the assignment operators for better readability.
- No changes in the logic or functionality of the code.

Signed-off-by: Vitali Quiering <vitali@quiering.com>
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    de6a2dc View commit details
    Browse the repository at this point in the history

  7. Refactor README for clarity and conciseness 

    - Removed redundant information and unnecessary sections
- Reorganized content for better flow and readability
- Updated formatting to improve visual presentation
- Fixed broken links and incorrect data source references
- Added a section for contributors and contribution guidelines
- Updated the About section with more detailed information about Cloud Posse
- Removed unnecessary sharing links and badges
- Updated copyright information
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0412824 View commit details
    Browse the repository at this point in the history

  8. Refactor Terraform code for route table ID retrieval 

    - Updated the method of retrieving route table IDs in both accepter.tf and requester.tf files to use a more efficient list comprehension.
- Removed unnecessary data blocks for aws_caller_identity and aws_region in requester.tf as they were not being used.

Signed-off-by: Vitali Quiering <vitali@quiering.com>
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6183dfb View commit details
    Browse the repository at this point in the history

  9. Update README and documentation 

    - Refactor README to improve readability and update links
- Remove unused data sources from terraform documentation
- Update contributing guidelines and community information
- Add details about commercial support and licensing
- Remove unnecessary markdownlint comments
    @vquie
    vquie committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    60147e7 View commit details
    Browse the repository at this point in the history