Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka): Update to github.com/cloudquery/plugin-sdk/v3 #10902

Merged
merged 4 commits into from
May 23, 2023

Conversation

bbernays
Copy link
Collaborator

Summary

closes #10721

@bbernays bbernays requested a review from a team as a code owner May 23, 2023 14:36
@bbernays bbernays requested review from hermanschaaf and removed request for a team May 23, 2023 14:36
@cq-bot cq-bot added the kafka label May 23, 2023
Copy link
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK, but shouldn't it also update the filetypes?

@cq-bot cq-bot added the aws label May 23, 2023
@cq-bot cq-bot removed the aws label May 23, 2023
@bbernays
Copy link
Collaborator Author

It's OK, but shouldn't it also update the filetypes?

There seem to be issues in V3 of the filetypes library surrounding parquet implementation.

So as soon as that is resolved we can update the library... In the mean time at least this destination will be able to be used with Arrow sources

@bbernays bbernays added the automerge Automatically merge once required checks pass label May 23, 2023
@bbernays bbernays added automerge Automatically merge once required checks pass and removed automerge Automatically merge once required checks pass labels May 23, 2023
@kodiakhq kodiakhq bot merged commit ba96208 into cloudquery:main May 23, 2023
@bbernays bbernays deleted the update-kafka-v3 branch May 23, 2023 21:24
kodiakhq bot pushed a commit that referenced this pull request Jun 1, 2023
🤖 I have created a release *beep* *boop*
---


## [3.1.0](plugins-destination-kafka-v3.0.1...plugins-destination-kafka-v3.1.0) (2023-06-01)


### Features

* **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d))
* **kafka:** Update to github.com/cloudquery/plugin-sdk/v3 ([#10902](#10902)) ([ba96208](ba96208)), closes [#10721](#10721)
* **kafka:** Upgrade to v3 ([#10931](#10931)) ([400e0e4](400e0e4))
* Update to `github.com/cloudquery/filetypes/v3` `v3.1.0` ([#10942](#10942)) ([40ca741](40ca741))


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.6.7 ([#11043](#11043)) ([3c6d885](3c6d885))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Migrate plugin/destination/kafka to github.com/cloudquery/plugin-sdk/v3
3 participants