Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): Process errors from Okta API #11161

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Jun 1, 2023

Closes #11149

BEGIN_COMMIT_OVERRIDE
feat(errors): Process errors from Okta API (#11161)

fix(backoff): Use 2 retries with minimum 30s of backoff interval (#11161)
END_COMMIT_OVERRIDE

@candiduslynx candiduslynx requested a review from a team as a code owner June 1, 2023 10:14
@candiduslynx candiduslynx requested review from hermanschaaf and removed request for a team June 1, 2023 10:14
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Jun 1, 2023
@candiduslynx candiduslynx requested a review from a team June 1, 2023 10:14
@cq-bot cq-bot added the okta label Jun 1, 2023
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
@hermanschaaf
Copy link
Member

This helps to expose the underlying error, but I suspect the underlying error might be related to my comment here: https://github.com/cloudquery/cloudquery/pull/10880/files#r1200452411 - can we also change the default backoff to be 30s or higher?

@candiduslynx
Copy link
Contributor Author

This helps to expose the underlying error, but I suspect the underlying error might be related to my comment here: https://github.com/cloudquery/cloudquery/pull/10880/files#r1200452411 - can we also change the default backoff to be 30s or higher?

Done in f3867b7

@kodiakhq kodiakhq bot merged commit 1f4fa5a into main Jun 1, 2023
@kodiakhq kodiakhq bot deleted the fix/okta/resolvers branch June 1, 2023 10:27
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


## [3.1.0](plugins-source-okta-v3.0.0...plugins-source-okta-v3.1.0) (2023-06-06)


### Features

* **errors:** Process errors from Okta API ([#11161](#11161)) ([1f4fa5a](1f4fa5a))


### Bug Fixes

* **backoff:** Use 2 retries with minimum 30s of backoff interval ([#11161](#11161)) ([1f4fa5a](1f4fa5a))
* **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92))
* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.3 ([#11150](#11150)) ([dc00994](dc00994))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Okta source plugin fails to unmarshall data
3 participants