feat: Add compliance dashboard #1255
Conversation
This also includes the following fixes: * check field is a string * execution_time is set only once and not in every subpolicy * execution_time uses native PostgreSQL now() instead of data which makes it work on windows
yevgenypats
requested review from
disq,
bbernays and
hermanschaaf
and removed request for
zagronitay
- Add data source row - Fix colors in Pass/Fail Distribution - Regenerate screenshot
|
|
||
| 1. Execute one or more of the above policies. | ||
| 2. Add the CloudQuery postgres database as a data source to Grafana (`Configuration -> Data Sources -> Add Data Source`) | ||
| 3. Import [dashboards/azure/azure_asset_inventory.json](../dashboards/grafana/compliance.json) into Grafana (`Import -> Upload JSON File`). |
There was a problem hiding this comment.
@yevgenypats I think we should move most of this Visualization section to a separate readme under the dashboards directory, and link to that section from here (maybe while keeping the screenshot). That way, you can look at the dashboards directory on its own and still know how to use it. WDYT?
There was a problem hiding this comment.
Yeah possible. I would still link to Visualization then from this README and also backlink from visualizations to policies.
There was a problem hiding this comment.
Yup, that's what I had in mind with my comment too 👍
some Postgres edge case in some queries where it couldn't do a cast implicitly 🤷 so it failed and I had to add that. |
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
- Change policy_exeuction to be set only once. - Change paths to be relative so policies can be executed from any directory. A copy-paste of cloudquery/cq-provider-aws#1255
- Change policy_exeuction to be set only once. - Change paths to be relative so policies can be executed from any directory. A copy-paste of cloudquery/cq-provider-aws#1255
Summary
This also includes the following fixes:
which makes it work on windows
NOTE: There is still work to be done in the dashboard and potentially some rough edges but I think this is a good start.
Other ideas: add severity to checks which can make some of the visualizations more interesting.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)go run ./docs/docs.goand committing the changes 📃