Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added glue data catalog encryption settings #1356

Merged
merged 3 commits into from
Aug 3, 2022
Merged

feat: Added glue data catalog encryption settings #1356

merged 3 commits into from
Aug 3, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Aug 1, 2022 •
edited
Loading

Summary

closes #1329

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review August 1, 2022 12:47
@amanenk amanenk requested a review from a team as a code owner August 1, 2022 12:47
@amanenk amanenk requested review from roneli and removed request for a team August 1, 2022 12:47
roneli
roneli approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanenk
Merge remote-tracking branch 'upstream/main' into glue_dc_encryption_…
56b6c6b 
…settings

# Conflicts:
#	client/mocks/glue.go
#	client/services.go
#	resources/provider/provider.go
@amanenk
mock generate
0a9a735
@amanenk amanenk merged commit a6c6246 into cloudquery:main Aug 3, 2022
@cq-bot cq-bot mentioned this pull request Aug 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::Glue::DataCatalogEncryptionSettings
2 participants
@amanenk @roneli