-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Add support for resource groups #1396
Conversation
I have one question, resource groups have a single field, |
It is common in AWS APIs that the
|
This looks good. Only a couple of small issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits around error handling
Reran the docs, for the linting error, that struct is placed at the bottom by |
@erezrokah @hermanschaaf @roneli Any insight or suggestion on how to proceed? |
@bbernays @adam-tylr We decided to disable the @adam-tylr If you bring your branch up-to-date with |
Brought up to date with main and re-generated. What is the |
Summary
Adds support for resource groups.
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code πgolangci-lint run
π¨ (install golangci-lint here)go run ./docs/docs.go
and committing the changes π