Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Add 'elasticache.clusters' resource #1400

Merged
merged 1 commit into from
Aug 10, 2022
Merged

feat: Add 'elasticache.clusters' resource #1400

merged 1 commit into from
Aug 10, 2022

Conversation

shimonp21
Copy link
Contributor

@shimonp21 shimonp21 commented Aug 8, 2022

Summary

Relates to: cloudquery/cloudquery#1368


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • Ensure the status checks below are successful βœ…

@shimonp21 shimonp21 requested a review from a team as a code owner August 8, 2022 14:53
@shimonp21 shimonp21 requested review from bbernays, roneli and hermanschaaf and removed request for a team August 8, 2022 14:53
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minor nits, overall looks great!

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the security groups double relation confused me for 1 minute ^^

@shimonp21 shimonp21 merged commit d27b0d9 into cloudquery:main Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants