-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add test connection #1682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
May 15, 2024
disq
commented
May 15, 2024
mnorbury
reviewed
May 15, 2024
Co-authored-by: Martin Norbury <martin.norbury@gmail.com>
disq
commented
May 15, 2024
⏱️ Benchmark results
|
disq
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
May 16, 2024 13:27
erezrokah
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments/questions
…mented by the Plugin
hermanschaaf
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a read through and it looks good to me, though I haven't read the CLI parts yet
disq
commented
May 17, 2024
disq
commented
May 17, 2024
erezrokah
reviewed
May 17, 2024
erezrokah
approved these changes
May 17, 2024
… implement TestConnection
kodiakhq bot
pushed a commit
that referenced
this pull request
May 20, 2024
🤖 I have created a release *beep* *boop* --- ## [4.43.0](v4.42.2...v4.43.0) (2024-05-20) ### Features * Add test connection ([#1682](#1682)) ([03493f5](03493f5)) ### Bug Fixes * **deps:** Update module github.com/apache/arrow/go/v16 to v16.1.0 ([#1693](#1693)) ([461e352](461e352)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.11.2 ([#1687](#1687)) ([30b52f7](30b52f7)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.13 ([#1690](#1690)) ([c35be5d](c35be5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements explicit test connection feature.