Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Webdav): Add overwrite support for moveFiles and copyFiles #1679

Merged
merged 4 commits into from
Apr 8, 2023

Conversation

xkeyC
Copy link
Contributor

@xkeyC xkeyC commented Mar 27, 2023

完善 Webdav 的 overwrite 操作,即 overwrite 为 true 时,先删除目标文件再进行后续操作。

我正在使用 Swift backup 备份手机数据,该软件具有 webdav 支持。

但我在更新备份时,会报告 Server 500 错误,问题发生在 webdav 的 moveFiles 操作。
根据我的分析,确认是 overwrite 未实现带来的文件名冲突问题。
此 PR 目的为修复这个错误。

Screenshot_2023-03-27-19-48-03-636_org swiftapps

Screenshot_2023-03-27-22-29-57-227_org swiftapps

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xkeyC seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HFO4 HFO4 merged commit 98788dc into cloudreve:master Apr 8, 2023
@HFO4
Copy link
Member

HFO4 commented Apr 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants