Move __hash__ to BaseAWSObject to support objects in dictionaries (Fixes

 #2204)

PR #2182 added support for troposphere object comparison. Upon release
there was an issue (#2196) where Parameter was not hashable and fixed in
PR #2200. This fix was a minimal one just for Parameter but PR #2204
showed use cases for the base object to be hashable as well.

tests/test_basic.py

@@ -122,6 +122,17 @@ def test___ne__(self):
         assert Parameter("param1") != Parameter("param2")
         assert Stack("stack1") != Stack("stack2")
 
+    def test___hash__(self):
+        """Test __hash__."""
+        from troposphere.ec2 import SecurityGroup
+
+        test_sg = SecurityGroup(
+            "TestSg",
+            VpcId="myVPC",
+            GroupDescription="Test Security Group",
+        )
+        _ = hash(test_sg)
+
     def test_badproperty(self):
         with self.assertRaises(AttributeError):
             Instance(

troposphere/__init__.py

@@ -431,6 +431,9 @@ def __eq__(self, other: object) -> bool:
     def __ne__(self, other: object) -> bool:
         return not self == other
 
+    def __hash__(self) -> int:
+        return hash(json.dumps({"title": self.title, **self.to_dict()}, indent=0))
+
 
 class AWSObject(BaseAWSObject):
     dictname = "Properties"
@@ -1115,6 +1118,3 @@ def check_type(t: type, v: Any) -> bool:
                         "%s can only be used with parameters of "
                         "the CommaDelimitedList type." % p
                     )
-
-    def __hash__(self) -> int:
-        return hash(json.dumps({"title": self.title, **self.to_dict()}, indent=0))