Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object equality fixes #2200

Merged
merged 1 commit into from Oct 26, 2023
Merged

Object equality fixes #2200

merged 1 commit into from Oct 26, 2023

Conversation

markpeek
Copy link
Member

  • Add hash to the Parameter class
  • Disable validation when doing BaseAWSObject object comparison eq

@markpeek markpeek mentioned this pull request Oct 25, 2023
Closed
@JohnPreston
Copy link
Contributor

That seems to address the issues with #2196 @markpeek 👍

@markpeek
Object equality fixes
b72637c 
- Add __hash__ to the Parameter class
- Disable validation when doing BaseAWSObject object comparison __eq__
@markpeek markpeek merged commit cfbd1d6 into main Oct 26, 2023
6 checks passed
markpeek added a commit that referenced this pull request Nov 10, 2023
@markpeek
Move __hash__ to BaseAWSObject to support objects in dictionaries (Fixes
68f07e5 
 #2204)

PR #2182 added support for troposphere object comparison. Upon release
there was an issue (#2196) where Parameter was not hashable and fixed in
PR #2200. This fix was a minimal one just for Parameter but PR #2204
showed use cases for the base object to be hashable as well.
@markpeek markpeek deleted the markpeek-issue-2196 branch December 6, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markpeek @JohnPreston