add support for object comparison #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITProKyle
force-pushed
the
feat/object-comparison
branch
from
856199c
to
3546e9a
Compare
ITProKyle
force-pushed
the
feat/object-comparison
branch
from
3546e9a
to
b8e4e29
Compare
|
Thank you for adding this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to compare objects.
Why This Is Needed
An advantage to using troposphere is being able to unit test various iterations of a dynamic template. However, the lack of support for being able to compare objects with one another makes these test cumbersome to write.
Resolves #1821
What Changed
Added
.to_json()method to base classes.__eq__()and.__ne__()methods to base classes.to_json()method for comparison of same objects created from the same class to ensure properties are sorted in the same orderAWSHelperFnto supportTags) uses.to_dict()instead of converting both to a JSON stringAWSHelperFn.__hash__()tests/test_tags.py:TestTags.test_Unsortablewas failing withTypeError: unhashable type: 'Sub'without it