[CLOUDTRUST-2295] Bridge endpoint to self-ask for an email validation #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1874
💛 - Coveralls |
fperot74
commented
Feb 19, 2020
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "github.com/cloudtrust/keycloak-client" | ||
| branch = "dev" | ||
| branch = "jira-2296" |
There was a problem hiding this comment.
To be updated before merging
bsoniam
reviewed
Feb 20, 2020
| @@ -15,6 +16,12 @@ import ( | |||
| kc "github.com/cloudtrust/keycloak-client" | |||
| ) | |||
|
|
|||
| // Constants | |||
| const ( | |||
| ActionVerifyEmail = "VERIFY_EMAIL" | |||
There was a problem hiding this comment.
Yes... one comes from Keycloak, the other one comes from 2019.kc-sms
bsoniam
reviewed
Feb 20, 2020
pkg/account/component.go
Outdated
| @@ -27,6 +34,8 @@ type KeycloakAccountClient interface { | |||
| UpdateAccount(accessToken, realm string, user kc.UserRepresentation) error | |||
| GetAccount(accessToken, realm string) (kc.UserRepresentation, error) | |||
| DeleteAccount(accessToken, realm string) error | |||
| ExecuteActionsEmail(accessToken string, realmName string, actions []string) error | |||
| //ExecuteActionsEmail(accessToken string, actions []string, paramKV ...string) error | |||
There was a problem hiding this comment.
maybe remove the second line
bsoniam
approved these changes
Feb 20, 2020
fperot74
force-pushed
the
selfservice
branch
from
a9780fa
to
5fbdef5
Compare
harture
approved these changes
Feb 24, 2020
api/account/swagger-api_account.yaml
Outdated
| @@ -160,7 +160,22 @@ paths: | |||
| responses: | |||
| 200: | |||
| description: Successful operation. | |||
|
|
|||
| /account/send-verify-email: | |||
There was a problem hiding this comment.
Maybe we could remove the "send" in URL to have /account/verify-email as it would sounds more RESTful
pkg/account/component.go
Outdated
| var additionalInfos = map[string]string{"actions": strings.Join(actions, ",")} | ||
| var additionalBytes, _ = json.Marshal(additionalInfos) | ||
| var additionalString = string(additionalBytes) | ||
| c.reportEvent(ctx, "ACTION_EMAIL", database.CtEventRealmName, currentRealm, database.CtEventUserID, userID, database.CtEventAdditionalInfo, additionalString) |
There was a problem hiding this comment.
ACTION_EMAIL must be sent only for VERIFY_EMAIL ? If yes, maybe we should have another specific event for verify phone number ?
fperot74
force-pushed
the
selfservice
branch
2 times, most recently
from
61fac01
to
0a67a1f
Compare
[CLOUDTRUST-2296] Bridge endpoint to self-ask for a phone number validation [CLOUDTRUST-2299] Send email when user updates his email/phone. Unvalidate his account validation
fperot74
force-pushed
the
selfservice
branch
from
0a67a1f
to
b3c7a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CLOUDTRUST-2296] Bridge endpoint to self-ask for a phone number validation
[CLOUDTRUST-2299] Send email when user updates his email/phone. Unvalidate his account validation
Refers to: