Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDTRUST-2296] Add a method on account API to send execute actions email #26

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

fperot74
Copy link
Contributor

No description provided.

}
int expiration = Time.currentTime() + lifespan;
String redirectUri = null;
String clientId = Constants.ACCOUNT_MANAGEMENT_CLIENT_ID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where does this Constants come from ... I don't see it in imports neither in package. What am I missing ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from org.keycloak.models
(the code to send the mail is mainly copied from Keycloak)

.setUser(user)
.sendExecuteActions(link, TimeUnit.SECONDS.toMinutes(lifespan));

//audit.user(user).detail(Details.EMAIL, user.getEmail()).detail(Details.CODE_ID, accessCode.getCodeId()).success();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove and/or convert into standard event


//audit.user(user).detail(Details.EMAIL, user.getEmail()).detail(Details.CODE_ID, accessCode.getCodeId()).success();

//adminEvent.operation(OperationType.ACTION).resourcePath(session.getContext().getUri()).success();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove ?

@harture harture self-requested a review February 24, 2020 12:24
@fratt-elca fratt-elca self-requested a review February 24, 2020 13:38
Copy link
Contributor

@fratt-elca fratt-elca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retest OK!

@fperot74 fperot74 merged commit 4bc9c7f into cloudtrust:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants