Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDTRUST-2296] Add endpoint execute-actions-email in account client #46

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

fperot74
Copy link
Contributor

@fperot74 fperot74 commented Feb 19, 2020

Use new method implemented in cloudtrust/keycloak-rest-api-extensions#26

(+ more than 60 "lints" removed)

accountExtensionAPIPath = "/auth/realms/master/api/account/realms/:realm"
accountPasswordPath = accountExtensionAPIPath + "/credentials/password"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not removed, just moved 3 lines below... It was not logical to do accountExtensionAPIPath + "/credentials... rather than accountCredentialsPath + "...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not see this

@fratt-elca fratt-elca self-requested a review February 24, 2020 13:40
Copy link

@fratt-elca fratt-elca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retest OK!

@fperot74 fperot74 merged commit 1536498 into master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants