Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for pkg/app/client/retry/retry.go #419

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mamil
Copy link
Contributor

@mamil mamil commented Nov 25, 2022

What type of PR is this?

test: Adding missing tests or correcting existing tests
pkg/app/client/retry/retry.go test coverage reached 100%

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

为pkg/app/client/retry/retry.go添加测试

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Add tests for pkg/app/client/retry/retry.go
zh(optional): 为pkg/app/client/retry/retry.go添加测试

Which issue(s) this PR fixes:

#257

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 68.14% // Head: 68.29% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (30109d0) compared to base (d39a818).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #419      +/-   ##
===========================================
+ Coverage    68.14%   68.29%   +0.15%     
===========================================
  Files           90       92       +2     
  Lines         8632     8686      +54     
===========================================
+ Hits          5882     5932      +50     
- Misses        2389     2393       +4     
  Partials       361      361              
Impacted Files Coverage Δ
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/app/client/retry/retry.go 100.00% <0.00%> (ø)
pkg/app/client/retry/option.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mamil mamil force-pushed the retry-ut branch 2 times, most recently from 1570c7e to cda396c Compare November 25, 2022 07:44
@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit d709792 into cloudwego:develop Dec 5, 2022
@mamil mamil deleted the retry-ut branch December 5, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants