-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/init nuxt app #68
Conversation
@dekanbro Can you explain the purpose of this pull request? Since I'm also working on the frontend stuff, we have to coordinate in some way. I don't really like the idea of rewriting everything from scratch. I also think that the existing tooling is better than the one you are proposing here (in particular, typescript would better suit our project, because MACI modules are written in typescript). |
@xuhcc sorry for the lack of transparency as the decision happened in a different channel I think, am happy to invite you to the Raid Guild Discord channel as well. We've discussed and intend to bring over all of your work. The Nuxt decision was mine as I prefer its structure, magic, and support by the Vue community. I'm happy to implement typescript if you're familiar, I don't believe the two setups to be mutually exclusive, the reasoning for not including typescript was that neither @dekanbro or myself are familiar with it and it presented more of a hurdle than feature. |
Could you or @dekanbro rebase this branch onto
OK, I'm not very familiar with Vue ecosystem so let's use Nuxt if you think it is better.
Yeah, we already use it in the
I'd like to keep the discussions in our channels (although maybe I'll join Raid Guild someday 😉). |
@dekanbro It seems that you did a merge instead of rebase, and for some reason GitHub now shows the diff incorrectly and it's hard to review. Please do a rebase:
In the end you should get clean linear history; then you can just force-push it. I just did it myself here: https://github.com/clrfund/monorepo/commits/nuxt |
hmm i did do that. any other ideas? |
Maybe we're using different versions of git (I'm on 2.27.0). |
On the subject of PR:
(that's a preliminary review, I didn't yet actually run the code because of 5.) |
7217b4e
to
c3fc313
Compare
@xuhcc I followed your suggestion but somehow totally botched this, but it looks like you figured it out in https://github.com/clrfund/monorepo/commits/nuxt, why don't we just merge that? |
c3fc313
to
c93e82b
Compare
@proofoftom no worries, I fixed it :) |
3: yarn keeps creating the root |
Yup, these both sound like good solutions to me 👍 |
Fix nanoid dependency issue on Node v11
No description provided.