Dapp: Display list of recipients #61
Conversation
| @@ -7,6 +7,7 @@ | |||
| "node": "buidler node --port 18545", | |||
| "deploy:local": "yarn clean && yarn build && buidler run --network localhost scripts/deploy.ts", | |||
| "deploy:goerli": "yarn clean && yarn build && buidler run scripts/goerli.ts", | |||
| "deployTestRound:local": "yarn buidler run --network localhost scripts/deployTestRound.ts", | |||
There was a problem hiding this comment.
I don't think yarn is needed in this command but it probably doesn't hurt either.
| - Deploying MACI instance. | ||
|
|
||
| ``` | ||
| yarn buidler run --network localhost scripts/deployTestRound.ts |
There was a problem hiding this comment.
Same as above: yarn deployTestRound:local
| ### Deploy factory contract | ||
|
|
||
| ``` | ||
| yarn buidler run --network localhost scripts/deploy.ts |
There was a problem hiding this comment.
Couldn't this simply be yarn deploy:local?
| @@ -23,7 +23,7 @@ | |||
| "test": "yarn workspaces run test", | |||
| "test:contracts": "yarn workspace @clrfund/contracts run test", | |||
| "test:web": "yarn workspace @clrfund/vue-app run test", | |||
| "deploy:local": "yarn workspace @clrfund/contracts run deploy:local", | |||
| "deploy:local": "yarn workspace @clrfund/contracts run deploy:local && yarn workspace @clrfund/contracts run deployTestRound:local", | |||
There was a problem hiding this comment.
I wonder if we'll always want a test round deployed, or rather if there's a case where we might not want to have one deployed for testing? If the latter is true in any case we might want to separate this into another script. Not a big deal though.
There was a problem hiding this comment.
I think we'll want the test round most of the time.
We may want to see how frontend responds to the situation when no round is deployed, but in that case we can simply run:
yarn workspace @clrfund/contracts run deploy:local
yarn start:web
instead of
yarn start:dev
Resolves #53
Partially implements #29