Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3D SBS mode (not found in any existing media players) #127

Closed
wants to merge 3 commits into from

Commits on Feb 7, 2018

  1. Configuration menu
    Copy the full SHA
    7f14b47 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Steroscopic 3D video and images (Specifically, Side by Side) usually …

    …need to be edited in some software before they can be presented on a 3D TV as the left and right halves of the image must be "squshed" horisontally in place (so a large black column appears in the middle and two smaller columns on the left and right edge).
    
    Additionally, fine adjustments to the seperation and the left/right eye elevation need to be made to correct for lens calibration issues with the source recording.
    Currently there is no playback software which allows the user to make these adjustments to the source video in real time.
    This feature provides all this functionality allowing raw 3D SBS content to be viewed on a TV without the need of recompression and time consuing video/image editing
    
    The keys for controlling all this are within the hot key screen at the bottom and are currently mapped in a similar form to the WASD movement but
    using the IJKL keys to avoid conflicing with more critical keys.
    
    I and K shift the left eye up/down and the right eye down/up
    J and L shift the eyes apart and closer together.
    The top left and right of these keys are the U and O keys which shrink and enlarge the left and right images.
    Over to the left, the 'S' key enables and disables the horisontal Squish of each eye. This is default to enabled.
    The purpose is in case someone has pre-squished left and right eyes but wants to adjust the seperation/elevation.
    
    To enable/disable all this 3D functionality, simply press the '3' key.
    
    A sample 3D SBS image is included for testing.
    
    Note: There was an error when I was trying to compile the latest source before doing this work in MainFrm.cpp so I did a hacky fix (type casting  CComQIPtr<IBaseFilter> pBF = (CComQIPtr<IBaseFilter>)(bIsSplitter ? (CComQIPtr<IBaseFilter>) pSS : (CComQIPtr<IBaseFilter>)pObject); )
    Jarvis committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    b3334ee View commit details
    Browse the repository at this point in the history
  2. Removed the sample image from the repo.

    Improved the shifting code in the renderer so it scales correctly when the window resizes.
    Adding the missing MainFrm.h file changes.
    Removed the Next Subtitle key binding so it doesn't clash with the Squish key. (yes, controversial, happy to use a different key, just doing this for now to fix the clash)
    Jarvis committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    f679fd1 View commit details
    Browse the repository at this point in the history