Feature 3D SBS mode (not found in any existing media players) #127
Conversation
…need to be edited in some software before they can be presented on a 3D TV as the left and right halves of the image must be "squshed" horisontally in place (so a large black column appears in the middle and two smaller columns on the left and right edge). Additionally, fine adjustments to the seperation and the left/right eye elevation need to be made to correct for lens calibration issues with the source recording. Currently there is no playback software which allows the user to make these adjustments to the source video in real time. This feature provides all this functionality allowing raw 3D SBS content to be viewed on a TV without the need of recompression and time consuing video/image editing The keys for controlling all this are within the hot key screen at the bottom and are currently mapped in a similar form to the WASD movement but using the IJKL keys to avoid conflicing with more critical keys. I and K shift the left eye up/down and the right eye down/up J and L shift the eyes apart and closer together. The top left and right of these keys are the U and O keys which shrink and enlarge the left and right images. Over to the left, the 'S' key enables and disables the horisontal Squish of each eye. This is default to enabled. The purpose is in case someone has pre-squished left and right eyes but wants to adjust the seperation/elevation. To enable/disable all this 3D functionality, simply press the '3' key. A sample 3D SBS image is included for testing. Note: There was an error when I was trying to compile the latest source before doing this work in MainFrm.cpp so I did a hacky fix (type casting CComQIPtr<IBaseFilter> pBF = (CComQIPtr<IBaseFilter>)(bIsSplitter ? (CComQIPtr<IBaseFilter>) pSS : (CComQIPtr<IBaseFilter>)pObject); )
rtrded
changed the title
|
MainFrm.h got reverted somehow so that file's changes are missing. Just rewriting that code and will then do a commit. |
Improved the shifting code in the renderer so it scales correctly when the window resizes. Adding the missing MainFrm.h file changes. Removed the Next Subtitle key binding so it doesn't clash with the Squish key. (yes, controversial, happy to use a different key, just doing this for now to fix the clash)
|
Removed the sample image from the repo. |
|
I am not really interested in adding exotic options for wrongly encoded files. I mean how common are such files? Replacing existing hotkeys is unacceptable. "3" is already in use (Menu>View>Presets). |
|
Yeh, I mentioned on the ticket here that I'm happy to change the hotkeys to we see fit. Here are three use cases: My camera has a 3D lens which if the camera is perfectly level then you have to tip your head to see the 3D image. Being able to offset one eye against the other vertically without having to run the raw video through a video editor and mess about rencoding is a god send. (why I spent 4 days doing this). 3D Cameras often produce videos deigned for you to view with a hand held prism lens thing. The actual images are not "squished". To view these on a TV which normally assumes videos are "squished" when given in SBS format, you need to run them through a video editor and splice the video in half, seperate them so they are 25% offset in each direction and then squish them 50% each. This is annoying, time consuming and means you need two copies for your video. Being able to watch 3D videos from a camera nativly on your 3D TV is another god send. (again, why I spent 4 days doing this feature) Some (but not all) 3D TVs have the ability to adjust the seperation of the images. By having this in the player it means anyone can do this regardless of their TV. I'm well aware the way the hotkeys have been done has made this seem like this feature is meant to be "front and center" but that is not my goal at all. I discreetly added the feature in the hot keys menu only below everything elese. The only thing I've done wrong which I'm fully aware of and keen to fix, is using hot key buttons that are already assigned to things such as 'O' for opening the options menu and 'S' for advancing the Substitles. I checked '3' and it doesn't appear to be in use for me although I was checking the original MPC-HC and not the forked clsid2 version. |
|
1 second example video clip from a 3D camera. |
|
One other reason, my mum has a lazy eye which means one eye droops a little. She finds if the right eye on a 3D image is raised, it makes watching 3D actually 3D. |
|
Also, we do have stretch/squish a speed and offset ability for 2D content. So it doesn't seem too ureasonable to have that same functionality for 3D content. |
|
Found an issue during testing - only right eye shows if 10bit output is enabled. |
Steroscopic 3D video and images (Specifically, Side by Side) usually need to be edited in some software before they can be presented on a 3D TV as the left and right halves of the image must be "squshed" horisontally in place (so a large black column appears in the middle and two smaller columns on the left and right edge).
Additionally, fine adjustments to the seperation and the left/right eye elevation need to be made to correct for lens calibration issues with the source recording.
Currently there is no playback software which allows the user to make these adjustments to the source video in real time. This feature provides all this functionality allowing raw 3D SBS content to be viewed on a TV without the need of recompression and time consuing video/image editing
The keys for controlling all this are within the hot key screen at the bottom and are currently mapped in a similar form to the WASD movement but using the IJKL keys to avoid conflicing with more critical keys.
I and K shift the left eye up/down and the right eye down/up
J and L shift the eyes apart and closer together.
The top left and right of these keys are the U and O keys which shrink and enlarge the left and right images.
Over to the left, the 'S' key enables and disables the horisontal Squish of each eye. This is default to enabled.
The purpose is in case someone has pre-squished left and right eyes but wants to adjust the seperation/elevation.
To enable/disable all this 3D functionality, simply press the '3' key.
A sample 3D SBS image is included for testing.
Note: It works best with video because images only draw once so changes made to the 3D settings only update on screen if the window is resized.
Note: There was an error when I was trying to compile the latest source before doing this work in MainFrm.cpp so I did a hacky fix (type casting CComQIPtr pBF = (CComQIPtr)(bIsSplitter ? (CComQIPtr) pSS : (CComQIPtr)pObject); )
Note: I made this change on the original MPC-HC source accidentally when I meant to use the latest from the clsid2 fork. I have an identicle pull request to the original source as well if that helps see the exact changes I made clearer.
mpc-hc#207