Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube-dl Integration #2

Merged
merged 30 commits into from
Aug 20, 2018
Merged

Youtube-dl Integration #2

merged 30 commits into from
Aug 20, 2018

Conversation

nparkanyi
Copy link

From mpc-hc#196

nparkanyi and others added 29 commits September 9, 2017 21:11
@nparkanyi
isYoutubeURL()
e4829e5
@nparkanyi
update copyright
bb275f1
@nparkanyi
simplified isYoutubeURL, fixed typo
583dabc
@nparkanyi
Moved youtube-dl stuff to MainFrm, initial GetYoutubeHttpsStreams tes…
dbdb2d2 
…t implementation.
@nparkanyi
properly wait for process completion
fae6b34
@nparkanyi
initial youtube-dl pipe buffer implementation
d1389a5
@nparkanyi
youtube-dl pipe buffering relegated to worker threads to prevent I/O …
2ff8d86 
…deadlock
@nparkanyi
load youtube videos and playlists through the Open File dialogue.
deafa66
@nparkanyi
clear playlist when not appending
b78a429
@nparkanyi
some proper error handling for youtube-dl stuff
3c3615a
@nparkanyi
Use video title instead of unwieldy raw youtube stream urls.
6f7fa18
@nparkanyi
add normal youtube url to recent files list instead of raw https stre…
e936772 
…am url.
@nparkanyi
only call youtube-dl once
b1baada
@nparkanyi
load Youtube links from command line
404ab86
@nparkanyi
post to status bar when calling youtube-dl
e6589a9
@nparkanyi
fixed signed/unsigned mismatch
c4fbbfe
@nparkanyi
Don't call OpenCurPlaylistItem() when appending youtube video to play…
3319262 
…list.
@nparkanyi
using -f option in youtube-dl allows us to get audio and video in one…
30784b8 
… URL
@nparkanyi
Call youtube-dl -J and parse JSON with rapidjson (CYoutubeDLInstance)
aff39e1
@nparkanyi
updated project files to include YoutubeDL.{cpp,h}.
7796822
@nparkanyi
drag-n-drop support for youtube-dl urls
8e3ec16
@nparkanyi
removed leftover crap
34fd985
@nparkanyi
fixed typos
1dd4a5c
@Nevcairiel @XhmikosR
HdmvClipInfo: Support UHD Blu-ray discs (mpc-hc#199)
7f14b47
@nparkanyi
Merge https://github.com/mpc-hc/mpc-hc into youtube-dl
b60bd35
@nparkanyi
added maximum video height option under advanced settings
c3b496b
@nparkanyi
Use original URL when loading youtube-dl videos from Favorites.
ed39301
@nparkanyi
obey youtube-dl audio-only flag on videos with split audio/video stre…
6ef0b8b 
…ams; added copyright header
@nparkanyi
Merge https://github.com/clsid2/mpc-hc into youtube-dl_clsid2
fcb0f2b
@clsid2
Copy link
Owner

clsid2 commented Apr 29, 2018

I will look at this next month. I have been busy.

@clsid2 clsid2 merged commit 9fd417e into clsid2:develop Aug 20, 2018
@clsid2
Copy link
Owner

clsid2 commented Aug 21, 2018

Another improvement could be to store the original URL in the playlist. If that is possible in a clean way.

@b7398564
Copy link

Any release installer programmed for this youtube-dl implementation? It's been more than 2 months since the last update.

Will be waiting.

@nparkanyi
Copy link
Author

Here is a development build: https://drive.google.com/open?id=1HQl6vmaA5T7FQJnZ7Xd52yzE78xf79vE

@mkruer mkruer mentioned this pull request May 11, 2020
Closed
@adipose adipose mentioned this pull request Jul 29, 2020
Closed
@adipose adipose mentioned this pull request Aug 7, 2020
Closed
@karelholubicka karelholubicka mentioned this pull request Sep 14, 2020
Closed
@Disappeaer Disappeaer mentioned this pull request Apr 15, 2021
Closed
@chinagreenelvis chinagreenelvis mentioned this pull request Jan 20, 2022
Closed
@adipose adipose mentioned this pull request Mar 22, 2022
Closed
@adipose adipose mentioned this pull request Mar 30, 2022
Closed
@gwendal-g gwendal-g mentioned this pull request May 16, 2022
Closed
@syffer72 syffer72 mentioned this pull request May 23, 2022
Closed
@VetaLioSTV VetaLioSTV mentioned this pull request Jan 21, 2023
Closed
@chelpus chelpus mentioned this pull request May 12, 2023
Closed
@ryehamstrawberry ryehamstrawberry mentioned this pull request Nov 15, 2023
Closed
@0xotHik 0xotHik mentioned this pull request Dec 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nparkanyi @clsid2 @b7398564 @Nevcairiel