Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the alert components modular #106

Closed
youhaveme9 opened this issue Feb 19, 2023 · 5 comments
Closed

Make the alert components modular #106

youhaveme9 opened this issue Feb 19, 2023 · 5 comments
Assignees
@sarkartanmay393
Labels
EASY good first issue Good for newcomers JWOC WOC

Comments

@youhaveme9
Copy link
Member

Alert messages and descriptions should be passed through the constructor
@youhaveme9 youhaveme9 changed the title Make the alert conponents modular Make the alert components modular Feb 19, 2023
@sarkartanmay393
Copy link
Contributor

@Roshaen I would like to work on it. And can you tell me a little more about the changes, I've to perform.

@Bhavikk01
Copy link
Collaborator

Bhavikk01 commented Feb 20, 2023 •
edited
Loading

@sarkartanmay393
What you have to do is you have to make the component dynamic means if someone is using this component then he/she only have to pass the properties or attributes and the desired widget would be delivered. So you have to take properties example title, description, color, etc from constructor and then have to use those values in your code.

@sarkartanmay393
Copy link
Contributor

Oh sure, @Roshaen I want to work under JWOC on this issue.

@youhaveme9
Copy link
Member Author

Ok @sarkartanmay393
Assigning you
Go through the Contribution guidelines to get started

@sarkartanmay393 sarkartanmay393 mentioned this issue Feb 22, 2023
Merged
@sarkartanmay393
Copy link
Contributor

@Roshaen Close the issue and set point label on my pr please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarkartanmay393 sarkartanmay393

Labels
EASY good first issue Good for newcomers JWOC WOC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youhaveme9 @sarkartanmay393 @Bhavikk01