Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Register method instead of MustRegister #4

Closed
MalloZup opened this issue Sep 15, 2019 · 1 comment
Closed

use Register method instead of MustRegister #4

MalloZup opened this issue Sep 15, 2019 · 1 comment

Comments

@MalloZup
Copy link
Contributor

Use Register method (https://godoc.org/github.com/openshift/origin/vendor/github.com/prometheus/client_golang/prometheus#Registry.Register)

This allow us to catch the error and print a error msg .

Mustregister just panic without giving the opportunity of catching errors

@MalloZup
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant