Skip to content

Commit

Permalink
PublicAccessBlock: test 404 on no block configuration
Browse files Browse the repository at this point in the history
Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket:

Refs: ceph/ceph#55652
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
  • Loading branch information
clwluvw committed Feb 20, 2024
1 parent 997f78d commit 3056e6d
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions s3tests_boto3/functional/test_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -12590,16 +12590,22 @@ def test_get_nonpublicpolicy_deny_bucket_policy_status():
resp = client.get_bucket_policy_status(Bucket=bucket_name)
assert resp['PolicyStatus']['IsPublic'] == True

def test_get_default_public_block():
#client = get_svc_client(svc='s3control', client_config=Config(s3={'addressing_style': 'path'}))
def test_get_undefined_public_block():
bucket_name = get_new_bucket()
client = get_client()

resp = client.get_public_access_block(Bucket=bucket_name)
assert resp['PublicAccessBlockConfiguration']['BlockPublicAcls'] == False
assert resp['PublicAccessBlockConfiguration']['BlockPublicPolicy'] == False
assert resp['PublicAccessBlockConfiguration']['IgnorePublicAcls'] == False
assert resp['PublicAccessBlockConfiguration']['RestrictPublicBuckets'] == False
# delete the existing public access block configuration
# as AWS creates a default public access block configuration
resp = client.delete_public_access_block(Bucket=bucket_name)
assert resp['ResponseMetadata']['HTTPStatusCode'] == 204

response_code = ""
try:
resp = client.get_public_access_block(Bucket=bucket_name)
except ClientError as e:
response_code = e.response['Error']['Code']

assert response_code == 'NoSuchPublicAccessBlockConfiguration'

def test_put_public_block():
#client = get_svc_client(svc='s3control', client_config=Config(s3={'addressing_style': 'path'}))
Expand Down

0 comments on commit 3056e6d

Please sign in to comment.