Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting with emojis #43

Closed
seahindeniz opened this issue Mar 15, 2019 · 2 comments
Closed

Conflicting with emojis #43

seahindeniz opened this issue Mar 15, 2019 · 2 comments

Comments

@seahindeniz
Copy link

If header contains emoji, plugin doesn't work as expected

Expected result

<ul>
  <li>
    <a href="#h1-heading-8-)">h1 Heading 8-)</a>
  </li>
</ul>

<h1 id="h1-heading-8-)">h1 Heading <img class="emoji" draggable="false" alt="😎" src="https://twemoji.maxcdn.com/2/72x72/1f60e.png"></h1>

OR

Expected result

<ul>
  <li>
    <a href="#h1-heading">h1 Heading 8-)</a>
  </li>
</ul>

<h1 id="h1-heading">h1 Heading <img class="emoji" draggable="false" alt="😎" src="https://twemoji.maxcdn.com/2/72x72/1f60e.png"></h1>

Actual result

<ul>
  <li>
    <a href="#h1-heading-8-)">h1 Heading 8-)</a>
  </li>
</ul>

<h1 id="h1-heading">h1 Heading <img class="emoji" draggable="false" alt="😎" src="https://twemoji.maxcdn.com/2/72x72/1f60e.png"></h1>
@seahindeniz seahindeniz changed the title Conficting with Emoji Conflicting with emojis Mar 16, 2019
@trolologuy
Copy link

Same issue with font awesome.
Here's the markdown:
## <font-awesome-icon icon="language"/> Spoken Languages
Results in this link:
#font-awesome-icon-icon-language-spoken-languages
Which is non-valid.
Everything between < >should probably be ignored.

@martinlissmyr
Copy link
Collaborator

Closing as noone seems to want to do a fix for it. If you create a with PR with the necessary fixes I'd accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants