Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from a locally generated Conan package, to one hosted on conan-center.io #302

Closed
7 tasks done
cmannett85 opened this issue Mar 24, 2023 · 0 comments · Fixed by #323
Closed
7 tasks done

Switch from a locally generated Conan package, to one hosted on conan-center.io #302

cmannett85 opened this issue Mar 24, 2023 · 0 comments · Fixed by #323
Assignees
@cmannett85
Labels
ci Continuous integration change

Comments

@cmannett85
Copy link
Owner

cmannett85 commented Mar 24, 2023 •
edited
Loading

#239 was just a proof-of-concept, nobody would want to build the package locally as a dependency for their project. The end goal was always to have an 'official' recipe on conan-center that builds from the specified version tag, much like how we do for vcpkg.

We need to target v1.3, so this needs doing after the release (#303)!

  • Port the local conanfile.py to a conan-center-index recipe, following their rules
  • Copy the Conan test package into the recipe test package
  • Find a way to test locally
  • Move the vcpkg test project into a more appropriate folder - having it in scripts/ci folder is the wrong place
  • Merge into upstream
  • Update merge checker to get the Conan package from conan-center and build the test project
  • Update GHA filters file

conan-io/conan-center-index#16736
@cmannett85 cmannett85 added the ci Continuous integration change label Mar 24, 2023
@cmannett85 cmannett85 self-assigned this Apr 7, 2023
@cmannett85 cmannett85 mentioned this issue Apr 7, 2023
Closed
cmannett85 added a commit that referenced this issue Apr 7, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
f499e19 
…conan-center.io

WIP
cmannett85 added a commit that referenced this issue Apr 7, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
0ad5789 
…conan-center.io

WIP
cmannett85 added a commit that referenced this issue Apr 13, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
d1b38c9 
…conan-center.io

Fix #302
@cmannett85 cmannett85 mentioned this issue Apr 13, 2023
Merged
cmannett85 added a commit that referenced this issue Apr 13, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
62c17a6 
…conan-center.io

Fix #302
cmannett85 added a commit that referenced this issue Apr 13, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
0d85620 
…conan-center.io

Fix #302
cmannett85 added a commit that referenced this issue Apr 13, 2023
@cmannett85
#302 Switch from a locally generated Conan package, to one hosted on …
4bbab66 
…conan-center.io

Fix #302
cmannett85 added a commit that referenced this issue Apr 13, 2023
@cmannett85
Merge pull request #323 from cmannett85/issue_302
fdfd3ef 
#302 Switch from a locally generated Conan package, to one hosted on …
cmannett85 added a commit that referenced this issue Aug 6, 2023
@cmannett85
arg_router v1.4.0
f04bf6c 
Bug fixes
* #330, Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Improvements
* #302, Switch from a locally generated Conan package, to one hosted on conan-center.io
* #314, Add support for multi-value arguments
* #315, CMake function to generate translation type headers from simple text files
* #317, Enable/disable nodes at runtime
* #318, Skip irrelevant GHA jobs
* #321, Add variable list length end token
* #325, Create copyright checker git hook
* #332, Extend pre-commit hook to include clang-format
* #335, Use Levenshtein distance to suggest possibly misspelt arguments
@cmannett85 cmannett85 mentioned this issue Aug 6, 2023
Merged
cmannett85 added a commit that referenced this issue Aug 6, 2023
@cmannett85
arg_router v1.4.0 (#343)
c0d5f11 
Bug fixes
* #330, Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Improvements
* #302, Switch from a locally generated Conan package, to one hosted on conan-center.io
* #314, Add support for multi-value arguments
* #315, CMake function to generate translation type headers from simple text files
* #317, Enable/disable nodes at runtime
* #318, Skip irrelevant GHA jobs
* #321, Add variable list length end token
* #325, Create copyright checker git hook
* #332, Extend pre-commit hook to include clang-format
* #335, Use Levenshtein distance to suggest possibly misspelt arguments
cmannett85 added a commit that referenced this issue Aug 8, 2023
@cmannett85
arg_router v1.4.0 (#344)
b3dab2e 
* Update vcpkg submodule commit for v1.3.0 recipe

* #312 Reduce code duplication in GHAs

Fix #312

* README.md grammar and spelling improvements

* #318 Skip irelevant GHA jobs

Fix #318

* #321 Add variable list length end token

Fix #321

* Fix clang-format error

* Updating README.md unit test coverage badge

* #302 Switch from a locally generated Conan package, to one hosted on conan-center.io

Fix #302

* Fixed copyrights

* Moved Conan jobs back into merge checker workflow

* Add Conan to README's installation options list

* #314 Add support for multi-value arguments (#326)

* #314 Add support for multi-value arguments

Fix #314

* Fix linting, Win and GCCv9 compilation errors

* Added missing tuple include

* Moved tuple include...

* Multiple clang-tidy fixes

Still can't reproduce the GCCv9 error locally.

* Fix missing MSVC toolset for local builds

Updated timeout time

* Increased timeouts again

Windows tests are hanging, so disabling for now and will create a bug ticket.

* Updating README.md unit test coverage badge

* #327 Fix MSVC builds (#328)

* #327 Fix MSVC builds

Fix #327

* Fixed copyright year.

* Extended MSVC test run timeout

* Fixed MSVC assert failure

* Updating README.md unit test coverage badge

* #325 Create copyright checker git hook (#329)

Fix #325

* #330 Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN (#331)

* #330 Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Fix #330

Also:
* Suppressing deprecation warnings in unit tests on Windows
* Workarounds for invalid C4702 (unreachable code) warnings on MSVC

* Fixed formatting

* #332 Extend pre-commit hook to include clang-format (#333)

Fix #332

* #317 Enable/disable nodes at runtime (#334)

Fix #317

* #315 CMake function to generate translation type headers from simple  text files (#336)

Fix #315

* #338 arg_router_translation_generator isn't detecting changes in the TOML files (#339)

Fix #338

* #335 Use Levenshtein distance to suggest possibly misspelt arguments (#337)

* #335 Use Levenshtein distance to suggest possibly misspelt arguments

Fix #335

* #320 Review parsing code (#340)

Fix #320

* arg_router v1.4.0 (#343)

Bug fixes
* #330, Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Improvements
* #302, Switch from a locally generated Conan package, to one hosted on conan-center.io
* #314, Add support for multi-value arguments
* #315, CMake function to generate translation type headers from simple text files
* #317, Enable/disable nodes at runtime
* #318, Skip irrelevant GHA jobs
* #321, Add variable list length end token
* #325, Create copyright checker git hook
* #332, Extend pre-commit hook to include clang-format
* #335, Use Levenshtein distance to suggest possibly misspelt arguments

* Fix vcpkg_test_package CMakeLists.txt (#345)

Used incorrect target name.

* Added missing env vars to vcpkg test package GHA (#346)

* vcpkg test package needs C++20 for Windows build (#347)

* Disable Windows vcpkg test package for merge_checker (#348)

v1.3.0 cannot be built in the latest MSVC, so this test is broken until vcpkg is carrying the v1.4.0 package.

* clang_cl example build fix (#350)

* Fix clang_cl support in test package (#352)

Added missing constexpr step limit increase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmannett85 cmannett85

Labels
ci Continuous integration change
Projects
No open projects
arg_router v1.4
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#302 Switch from a locally generated Conan package, to one hosted on … cmannett85/arg_router
1 participant
@cmannett85