Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication in GHAs #312

Closed
cmannett85 opened this issue Mar 28, 2023 · 0 comments · Fixed by #313
Closed

Reduce code duplication in GHAs #312

cmannett85 opened this issue Mar 28, 2023 · 0 comments · Fixed by #313
Assignees
@cmannett85
Labels
ci Continuous integration change

Comments

@cmannett85
Copy link
Owner

There a mix of techniques we can use:

  1. Composite actions
  2. Matrices
@cmannett85 cmannett85 self-assigned this Mar 28, 2023
@cmannett85 cmannett85 added the ci Continuous integration change label Mar 28, 2023
cmannett85 added a commit that referenced this issue Mar 28, 2023
@cmannett85
#312 Reduce code duplication in GHAs
a1064b0 
WIP
cmannett85 added a commit that referenced this issue Mar 28, 2023
@cmannett85
#312 Reduce code duplication in GHAs
21d4911 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
7c5401a 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
5b3164b 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
8597b40 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
350b581 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
049f9ac 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
b167d8e 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
bb13610 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
6427247 
WIP
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
#312 Reduce code duplication in GHAs
9366367 
Fix #312
@cmannett85 cmannett85 mentioned this issue Mar 29, 2023
Merged
cmannett85 added a commit that referenced this issue Mar 29, 2023
@cmannett85
Merge pull request #313 from cmannett85/issue_312
4495677 
#312 Reduce code duplication in GHAs
@cmannett85 cmannett85 mentioned this issue Apr 6, 2023
Closed
cmannett85 added a commit that referenced this issue Aug 8, 2023
@cmannett85
arg_router v1.4.0 (#344)
b3dab2e 
* Update vcpkg submodule commit for v1.3.0 recipe

* #312 Reduce code duplication in GHAs

Fix #312

* README.md grammar and spelling improvements

* #318 Skip irelevant GHA jobs

Fix #318

* #321 Add variable list length end token

Fix #321

* Fix clang-format error

* Updating README.md unit test coverage badge

* #302 Switch from a locally generated Conan package, to one hosted on conan-center.io

Fix #302

* Fixed copyrights

* Moved Conan jobs back into merge checker workflow

* Add Conan to README's installation options list

* #314 Add support for multi-value arguments (#326)

* #314 Add support for multi-value arguments

Fix #314

* Fix linting, Win and GCCv9 compilation errors

* Added missing tuple include

* Moved tuple include...

* Multiple clang-tidy fixes

Still can't reproduce the GCCv9 error locally.

* Fix missing MSVC toolset for local builds

Updated timeout time

* Increased timeouts again

Windows tests are hanging, so disabling for now and will create a bug ticket.

* Updating README.md unit test coverage badge

* #327 Fix MSVC builds (#328)

* #327 Fix MSVC builds

Fix #327

* Fixed copyright year.

* Extended MSVC test run timeout

* Fixed MSVC assert failure

* Updating README.md unit test coverage badge

* #325 Create copyright checker git hook (#329)

Fix #325

* #330 Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN (#331)

* #330 Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Fix #330

Also:
* Suppressing deprecation warnings in unit tests on Windows
* Workarounds for invalid C4702 (unreachable code) warnings on MSVC

* Fixed formatting

* #332 Extend pre-commit hook to include clang-format (#333)

Fix #332

* #317 Enable/disable nodes at runtime (#334)

Fix #317

* #315 CMake function to generate translation type headers from simple  text files (#336)

Fix #315

* #338 arg_router_translation_generator isn't detecting changes in the TOML files (#339)

Fix #338

* #335 Use Levenshtein distance to suggest possibly misspelt arguments (#337)

* #335 Use Levenshtein distance to suggest possibly misspelt arguments

Fix #335

* #320 Review parsing code (#340)

Fix #320

* arg_router v1.4.0 (#343)

Bug fixes
* #330, Explicitly specify NOMINMAX and WIN32_LEAN_AND_MEAN

Improvements
* #302, Switch from a locally generated Conan package, to one hosted on conan-center.io
* #314, Add support for multi-value arguments
* #315, CMake function to generate translation type headers from simple text files
* #317, Enable/disable nodes at runtime
* #318, Skip irrelevant GHA jobs
* #321, Add variable list length end token
* #325, Create copyright checker git hook
* #332, Extend pre-commit hook to include clang-format
* #335, Use Levenshtein distance to suggest possibly misspelt arguments

* Fix vcpkg_test_package CMakeLists.txt (#345)

Used incorrect target name.

* Added missing env vars to vcpkg test package GHA (#346)

* vcpkg test package needs C++20 for Windows build (#347)

* Disable Windows vcpkg test package for merge_checker (#348)

v1.3.0 cannot be built in the latest MSVC, so this test is broken until vcpkg is carrying the v1.4.0 package.

* clang_cl example build fix (#350)

* Fix clang_cl support in test package (#352)

Added missing constexpr step limit increase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmannett85 cmannett85

Labels
ci Continuous integration change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#312 Reduce code duplication in GHAs cmannett85/arg_router
1 participant
@cmannett85