Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string comparison for ExtensionProperties #12

Closed
cmbruns opened this issue Aug 14, 2021 · 1 comment
Closed

string comparison for ExtensionProperties #12

cmbruns opened this issue Aug 14, 2021 · 1 comment
Assignees
@cmbruns

Comments

@cmbruns
Copy link
Owner

cmbruns commented Aug 14, 2021

so we can say "foo" in props
@cmbruns cmbruns added generator Related to the pyopenx code generator and removed generator Related to the pyopenx code generator labels Aug 14, 2021
@cmbruns
Copy link
Owner Author

cmbruns commented Aug 16, 2021

Fixed in dcb7313

  • convert to string
  • convert to bytes
  • compare to string for equality

@cmbruns cmbruns closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmbruns cmbruns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmbruns