Changes the temporary dir location to work on every system #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uses the system temp dir + pid combination to avoid renaming child folder to a parent folder, which fails on linux; * cleans up the temporary folder during emergency shutdown to avoid leaving orphan files; * still fails on linux when providing existing folder to the example command; * still does not initialize modules for the cloned example.
|
Thanks @ZloeSabo this is very helpful. I'll have final look this weekend. Can you please let me know which Linux distribution + version you are using? |
|
@Manvel i've checked with Alpine 3.8 and Mint 19. |
|
@ZloeSabo Fixes are published in the npm, should be available in the versions greater than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
folder to a parent folder, which fails on linux;
leaving orphan files;
command;