Conflicts between scripts

[swertz]

Hi,

It seems there are several plot1DScan.py files in the script directories of the various sub-packages... When running scram these get copied to the CMSSW bin folder in a random order and overwrite the "main" script, which is clearly undesirable. What's more, at least one is not an executable file, so it's not even found as a command.

It could be the case also for other scripts, I haven't checked. I can submit a PR to rename them but perhaps you have another preferred solution?

[adewit]

Thanks a lot for pointing it out! I wouldn't rename them, but instead make sure that only the plot1DScan.py that lives in CombineTools/scripts is executable (as there's no need for the modified versions specific to analyses to be executable). I can change this later today, or if you want to do it feel free to make a PR :-).

[swertz]

I'm afraid this won't be sufficient, as all these other */scripts/plot1DScan.py files will still be copied over to the $CMSSW_BASE/bin folder and potentially overwrite the main, executable script...

The consequence is that I won't be able to call the command plot1DScan.py but will have to explicitly call the full path to that script in CombineTools/scripts, which is clearly not convenient...

[adewit]

Ah sorry, I was under the impression that somehow the executables were written again but I see now that it's not the case. Pure luck that I've always dodged this bullet apparently ;-) Then yes, don't see another option than to rename the modified versions (while still making sure they are not executable so at least all those versions can still have a common name).