Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation tools #3

Closed
8 tasks
ajgilbert opened this issue Oct 27, 2015 · 0 comments
Closed
8 tasks

Validation tools #3

ajgilbert opened this issue Oct 27, 2015 · 0 comments
Assignees
Milestone

Comments

@ajgilbert
Copy link
Collaborator

Need a class with a configurable set of checks to perform on a CH instance. These checks would include:

  • Checking bin and process names are sufficiently unique. I.e. one observation per bin name, >= 1 uniquely-named processes per bin name
  • Ensuring shapes are present for all Observations, Processes and shape Systematics. Verify that the binning is identical in all bins
  • Negative histogram bins. Provide options for correcting these - set bins to zero, set to a small positive value, merge with adjacent bins. (though automated bin merging is a big task in its own right)
  • Processes with no systematic uncertainties
  • Systematic uncertainties not connected to any process
  • Bins with no background expectation (and in particular no background but finite signal)
  • Maybe give information about pdf parameters that will or won't be getting a constraint
  • Could also tie-in the nuisance summary code here, though it's not strictly validation

Will add more things as they come up.

@ajgilbert ajgilbert self-assigned this Oct 27, 2015
@ajgilbert ajgilbert added this to the nov-15 milestone Oct 27, 2015
@ajgilbert ajgilbert modified the milestones: moriond16, nov-15 Jan 28, 2016
mverzett pushed a commit to mverzett/CombineHarvester that referenced this issue May 31, 2017
mflechl pushed a commit that referenced this issue Dec 3, 2018
lucastorterotot pushed a commit to lucastorterotot/CombineHarvester that referenced this issue Dec 6, 2019
cardinia referenced this issue in cardinia/CombineHarvester Dec 12, 2019
adewit pushed a commit that referenced this issue Dec 17, 2020
acarvalh pushed a commit to acarvalh/CombineHarvester that referenced this issue Feb 1, 2021
Fix bug for BR systematics in 1l2tau and 2l2tau
tahuang1991 added a commit to tahuang1991/CombineHarvester that referenced this issue Feb 4, 2021
fixed the bug in error propagation for empty bins merging
lauridsj pushed a commit to lauridsj/CombineHarvester that referenced this issue Mar 28, 2024
Set the variance for the Yukawa templates to zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant