You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Suggest analogous script to run_scans.py but for analysis of scan data collected with python tools. Suggest name be "ana_scans.py"
Types of issue
Bug report (report an issue with the code)
Feature request (request for change which adds functionality)
Expected Behavior
Providing command line arguments to run the analysis tools:
macros/anaUltraScurve.py
macros/anaUltraThreshold.py
gem-plotting/latency/anaUltraLatency.py (suggest to rename from LatencyScanData.py to match naming convention)
Following in chamberInfo.py example also create an "anaInfo.py" file defining a dictionary of analysis type with analysis tool.
This should allow the DOC the ability to analyze any scan data taken and prepare configuration files and summary plots for posting to the elog.
Additionally suggest to separate analysis related options from qcoptions.py and create an anaoptions.py. Also suggest to limit "option bloat" in these options scripts. These scripts should only contain options that are common to multiple scripts (e.g. infilename or vfatmask). Options that are specific to just one script should be migrated out of here and only move to those scripts. This will improve the clarity of the help menus as many of the scripts right now dump a wall of text when calling help and many of the options provided take no action (e.g. --doLatency does nothing in ultraThreshold.py)
Current Behavior
Right now we have:
anaAllChambers.py
anaAllChambersThresh.py
These are two separate tools that have to be maintained separately, in addition to the analysis scripts themselves. This upgrade would depreciate these scripts and provide a single script for analysis that would serve as the central tool.
Context (for feature requests)
DOC does not presently have the tools to seamlessly analyze data taken from all scans, proposed change would fix.
This will also improve clarity of the help menu.
The text was updated successfully, but these errors were encountered:
After discussion in the July 18th GEM Operations & Online SW Meeting we decided to migrate all analysis tools from vfatqc-python-scripts to gem-plotting-tools.
Brief summary of issue
Suggest analogous script to run_scans.py but for analysis of scan data collected with python tools. Suggest name be "ana_scans.py"
Types of issue
Expected Behavior
Providing command line arguments to run the analysis tools:
Following in chamberInfo.py example also create an "anaInfo.py" file defining a dictionary of analysis type with analysis tool.
This should allow the DOC the ability to analyze any scan data taken and prepare configuration files and summary plots for posting to the elog.
Additionally suggest to separate analysis related options from qcoptions.py and create an anaoptions.py. Also suggest to limit "option bloat" in these options scripts. These scripts should only contain options that are common to multiple scripts (e.g. infilename or vfatmask). Options that are specific to just one script should be migrated out of here and only move to those scripts. This will improve the clarity of the help menus as many of the scripts right now dump a wall of text when calling help and many of the options provided take no action (e.g. --doLatency does nothing in ultraThreshold.py)
Current Behavior
Right now we have:
These are two separate tools that have to be maintained separately, in addition to the analysis scripts themselves. This upgrade would depreciate these scripts and provide a single script for analysis that would serve as the central tool.
Context (for feature requests)
DOC does not presently have the tools to seamlessly analyze data taken from all scans, proposed change would fix.
This will also improve clarity of the help menu.
The text was updated successfully, but these errors were encountered: