remove mkFit external

[slava77]

in connection with cms-sw/cmssw#36546

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[slava77]

@smuzaffar
is this PR really in conflict or is this some display/detection feature of github?

The status says Conflicting files mkfit.spec , which I guess is from #7592 from more than a week ago.
However, this PR just deletes the file and also the tests from yesterday in cms-sw/cmssw#36546 (comment) which include this PR passed.

[smuzaffar]

It is github feature. File deletion was based on a previous state of mkfit.spec which now has different contents. Can you please rebase this PR?

[cmsbuild]

Pull request #7528 was updated.

[slava77]

It is github feature. File deletion was based on a previous state of mkfit.spec which now has different contents. Can you please rebase this PR?

it is rebased now.

[slava77]

@cmsbuild please test with cms-sw/cmssw#36546

[smuzaffar]

test parameters:

• pull_request = mkFit external integration cmssw#36546
• full_cmssw = true

[smuzaffar]

please test
lets test a full build

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22435/summary.html
COMMIT: 8db5254
CMSSW: CMSSW_12_3_X_2022-02-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7528/22435/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @tvami Add 2021 MinimumBias express and prompt reco wf to limited cmssw#36942
• @pmandrik Move ecalcalib_dqm_sourceclient to Run-3 era cmssw#36958
• @dan131riley Make some L1Trigger config static pointers thread safe cmssw#36965
• @bsunanda Run3-alca218B Clean some of the Hcal calibration code in the test area of Calibration/HcalCalibalgos cmssw#36964
• @wouf bug fixes for Hydjets and Pyquen cmssw#36918
• @missirol add support for L1T-MuonShowers as trigger objects at HLT cmssw#36951
• @thomreis ECAL - Remove unused parameters from the multifit algorithm cmssw#36935

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22435/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22435/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libDataFormatsParticleFlowCandidate.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsJetReco.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsPhase2TrackerDigi.so
error: class 'pat::Muon' has a different checksum for ClassVersion 29. Increment ClassVersion to 30 and assign it to checksum 4221614933
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/PatCandidates/src/classes_def_objects.xml.generated with updated ClassVersion
>> Checking EDM Class Version for src/DataFormats/PatCandidates/src/classes_def_trigger.xml in libDataFormatsPatCandidates.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsProtonReco.so
@@@@ ----> OK  EDM Class Version 


[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22460/summary.html
COMMIT: 8db5254
CMSSW: CMSSW_12_3_X_2022-02-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7528/22460/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @CTPPS PPS: AlCaReco producer, content filters and testing files cmssw#36273
• @ChrisMisan Fix HPTDC timing PCL cmssw#36976
• @perrotta Remove dead assignments and simplify HLTmumutkFilter cmssw#36977
• @francescobrivio Add back L1CaloGeometry tag to HLT GT cmssw#36971

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22460/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e55bf/22460/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2e55bf/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2e55bf/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2e55bf/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3965107
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
tested with cms-sw/cmssw#36546