Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDFilters do not run in unScheduled mode although put in a path #24461

Closed
tocheng opened this issue Sep 4, 2018 · 8 comments
Closed

EDFilters do not run in unScheduled mode although put in a path #24461

tocheng opened this issue Sep 4, 2018 · 8 comments

Comments

@tocheng
Copy link
Contributor

tocheng commented Sep 4, 2018

The issue raised when reproducing SiPixelCalZeroBias ALCARECO using Express data.
CMSSW release CMSSW_10_2_0 was use.

To reproduce the ALCAREO, the following cmsDriver command is used
step3 --runUnscheduled -s ALCA:SiPixelCalZeroBias+PromptCalibProdSiPixel --nThreads 8 --data --era Run2_2018 --scenario pp --conditions 102X_dataRun2_Express_v1 --eventcontent ALCARECO --datatier ALCARECO --filein /store/express/Run2018C/ExpressPhysics/FEVT/Express-v1/000/319/579/00000/009E1EBD-5B86-E811-A875-A4BF0112F640.root -n -1

The path contains two EDFilters and one EDProducer as
https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiPixelQuality/python/ALCARECOSiPixelCalZeroBias_cff.py#L30

It turned out that if running in the scheduled mode,
SiPixelDetectorStatus_siPixelStatusProducer_siPixelStatus_ALCA.obj.fNevents = 0
SiPixelDetectorStatus_siPixelStatusProducer_siPixelStatus_ALCA.obj.fDetHits = 0
indicating no pixel hit store in ALCARECO because of the DCS filter

But if running in the unscheduled mode,
SiPixelDetectorStatus_siPixelStatusProducer_siPixelStatus_ALCA.obj.fNevents = 1483
SiPixelDetectorStatus_siPixelStatusProducer_siPixelStatus_ALCA.obj.fDetHits = 443068
indicating neither of the EDFilters worked during production.

This is unexpected as EDFilters should run so long as they are put in paths in unscheduled mode.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

A new Issue was created by @tocheng Tongguang.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

@tocheng this is expected behavior. When you use the --runUnscheduled in cmsDriver.py, the configuration has the call convertToUnscheduled(process) which removes all EDProducer from all Paths and will run those EDProducers whenever a module asks for the data. In your case, the PoolOutputModule asks for data from siPixelStatusProducer and therefore it will be run unscheduled.

One can mix running modules as scheduled and unscheduled by explicitly putting EDProducers that you want to run unscheduled into edm.Tasks rather than edm.Sequences and those EDProducers you want to run scheduled (i.e. with filtering) must just be on edm::Sequences.

@Dr15Jones
Copy link
Contributor

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tocheng
Copy link
Contributor Author

tocheng commented Sep 5, 2018

@Dr15Jones Thanks a lot for the explanation! Should I close the issue or you will sign it?

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

This issue is fully signed and ready to be closed.

@Dr15Jones
Copy link
Contributor

@tocheng please close this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants