[LTO - L1] Compiler warnings -Wodr and -Wstrict-overflow in L1 category

[aandvalenzuela]

Hello,

We have seen some compiler warnings of the type -Wodr and -Wstrict-overflow in LTO_X IBs (CMSSW_12_5_LTO_X_2022-07-07-1100 and CMSSW_12_5_LTO_X_2022-07-06-1100, for example) in some packages of the l1 category. See sample stack traces:

• L1Trigger/CSCTrackFinder reports -Wstrict-overflow:

>> Building shared library tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/libL1TriggerCSCTrackFinder.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -O1 -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCSectorReceiverLUT.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCSectorReceiverMiniLUT.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCSectorReceiverMiniLUT_parameters.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFCandidateBuilder.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFDTReceiver.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFDTReceiverLUT.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFMuonSorter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFPtLUT.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFPtMethods.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFSPCoreLogic.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFSectorProcessor.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFTrackBuilder.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTrackFinderDataTypes.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/parameters.cc.o -o tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/libL1TriggerCSCTrackFinder.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/biglib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/lib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/external/el8_amd64_gcc10/lib -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/static/el8_amd64_gcc10 -lL1TriggerCSCTriggerPrimitives -lL1TriggerDTTrackFinder -lDataFormatsL1CSCTrackFinder -lDataFormatsCSCDigi -lDataFormatsGEMDigi -lDataFormatsGEMRecHit -lDataFormatsCSCRecHit -lDataFormatsTrackingRecHit -lGeometryCSCGeometry -lGeometryGEMGeometry -lCondFormatsDataRecord -lGeometryCommonTopologies -lCondFormatsAlignment -lCondFormatsL1TObjects -lDataFormatsGeometryCommonDetAlgo -lGeometryRecords -lCondFormatsAlignmentRecord -lCondFormatsCSCObjects -lDataFormatsGeometrySurface -lDataFormatsL1GlobalCaloTrigger -lDataFormatsCLHEP -lDataFormatsEcalDetId -lDataFormatsGeometryVector -lDataFormatsL1CaloTrigger -lDataFormatsL1DTTrackFinder -lDataFormatsL1GlobalTrigger -lDataFormatsMuonDetId -lFWCoreFramework -lDataFormatsDetId -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lgsl -luuid -ltbb -llzma -lz -lCSCTrackFinderEmulation -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/src/L1Trigger/CSCTrackFinder/src/CSCTFSectorProcessor.cc: In member function 'run':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/2604283bf44a2288b36325ed38662fdd/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-09-1100/src/L1Trigger/CSCTrackFinder/src/CSCTFSectorProcessor.cc:1029:56: warning: assuming signed overflow does not occur when simplifying conditional to constant [-Wstrict-overflow]
  1029 |             (((trk->ptLUTAddress() >> 16) & 0xf) == 15 && trk->BX() - 2 == bx - shift)) {
      |                                                        ^
Copying tmp/el8_amd64_gcc10/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/libL1TriggerCSCTrackFinder.so to productstore area:
Leaving library rule at L1Trigger/CSCTrackFinder

• L1Trigger/TrackFindingTracklet reports -Wstrict-overflow:

>> Building shared library tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/libL1TriggerTrackFindingTracklet.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -DUSEHYBRID -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/AllInnerStubsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/AllProjectionsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/AllStubsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/CandidateMatchMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/CleanTrackMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/DTCLinkMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/FPGAWord.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/FitTrack.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/FullMatchMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Globals.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/HybridFit.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/InputLinkMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/InputRouter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/L1SimTrack.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/L1TStub.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/MatchCalculator.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/MatchEngine.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/MatchEngineUnit.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/MatchProcessor.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/MemoryBase.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/ProcessBase.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Projection.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/ProjectionRouter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/ProjectionTemp.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/PurgeDuplicate.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Residual.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/SLHCEvent.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Sector.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Stub.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/StubPairsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/StubTripletsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Timer.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Track.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackDer.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackDerTable.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackFitMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/Tracklet.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletCalculator.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletCalculatorBase.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletCalculatorDisplaced.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletConfigBuilder.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletEngine.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletEngineDisplaced.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletEngineUnit.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletEventProcessor.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletLUT.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletParametersMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletProcessor.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TrackletProjectionsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/TripletEngine.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMProjectionsMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMRouter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMRouterCM.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMStubME.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMStubTE.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMStubsMEMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/VMStubsTEMemory.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/imath.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/imath_HLS.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/imath_Verilog.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/imath_calculate.cc.o -o tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/libL1TriggerTrackFindingTracklet.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/biglib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/lib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/external/el8_amd64_gcc10/lib -L/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc10/external/cuda/11.5.2-c927b7e765e06433950d8a7eab9eddb4/lib64/stubs -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/static/el8_amd64_gcc10 -lL1TriggerTrackFindingTMTT -lDataFormatsJetReco -lDataFormatsParticleFlowCandidate -lDataFormatsParticleFlowReco -lDataFormatsEgammaCandidates -lDataFormatsMuonReco -lDataFormatsRecoCandidate -lSimTrackerTrackTriggerAssociation -lDataFormatsEgammaReco -lDataFormatsGsfTrackReco -lDataFormatsVertexReco -lSimDataFormatsTrackingAnalysis -lDataFormatsTrackReco -lDataFormatsGEMRecHit -lDataFormatsTrackCandidate -lDataFormatsTrackerRecHit2D -lDataFormatsCSCRecHit -lDataFormatsDTRecHit -lDataFormatsFTLRecHit -lDataFormatsTrajectorySeed -lL1TriggerTrackTrigger -lDataFormatsTrackingRecHit -lGeometryTrackerGeometryBuilder -lDataFormatsL1TrackTrigger -lMagneticFieldRecords -lCondFormatsDataRecord -lDataFormatsTrackerCommon -lGeometryCaloGeometry -lGeometryCommonTopologies -lCondFormatsAlignment -lDataFormatsBeamSpot -lDataFormatsCaloTowers -lDataFormatsEcalRecHit -lDataFormatsGeometryCommonDetAlgo -lDataFormatsHepMCCandidate -lDataFormatsSiStripCluster -lGeometryRecords -lGeometryTrackerNumberingBuilder -lCommonToolsUtilAlgos -lCondFormatsAlignmentRecord -lDataFormatsCandidate -lDataFormatsDTDigi -lDataFormatsEcalDigi -lDataFormatsGeometrySurface -lDataFormatsSiPixelDigi -lDataFormatsTrajectoryState -lDetectorDescriptionCore -lDetectorDescriptionDDCMS -lSimDataFormatsTrackerDigiSimLink -lCommonToolsUtils -lCondFormatsGeometryObjects -lDataFormatsCLHEP -lDataFormatsCaloRecHit -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lDataFormatsL1GlobalTrigger -lDataFormatsMuonDetId -lDataFormatsPhase2TrackerCluster -lDataFormatsSiPixelDetId -lDataFormatsSiStripDetId -lFWCoreFramework -lSimDataFormatsTrack -lSimDataFormatsVertex -lDataFormatsDetId -lDataFormatsFEDRawData -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lDataFormatsPhase2TrackerDigi -lDataFormatsScouting -lDataFormatsSiPixelCluster -lDataFormatsSiStripDigi -lFWCoreCommon -lFWCoreServiceRegistry -lSimDataFormatsGeneratorProducts -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lPhysicsToolsONNXRuntime -lCondFormatsSerialization -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lSimDataFormatsEncodedEventId -lDDAlign -lDDCond -lDDCore -lDDParsers -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lGeom -lThread -lMathCore -lRIO -lSmatrix -lboost_regex -lboost_serialization -lonnxruntime -lCore -lboost_thread -lboost_date_time -lCLHEP -lcudnn -lHepMCfio -lHepMC -lpcre -lbz2 -lcudart -lcudadevrt -lnvToolsExt -lgsl -luuid -lprotobuf -ltbb -lxerces-c -llzma -lz -lcuda -lfmt -lHepMC3 -lHepMC3search -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/TrackFindingTracklet/src/Tracklet.cc: In member function 'disk':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/TrackFindingTracklet/src/Tracklet.cc:784:3: warning: assuming signed overflow does not occur when simplifying comparison of absolute value and zero [-Wstrict-overflow]
   784 |   if (abs(d1) < min(abs(d2), abs(d3)))
      |   ^
Copying tmp/el8_amd64_gcc10/src/L1Trigger/TrackFindingTracklet/src/L1TriggerTrackFindingTracklet/libL1TriggerTrackFindingTracklet.so to productstore area:
Leaving library rule at L1Trigger/TrackFindingTracklet

• L1Trigger/RPCTrigger reports -Wodr:

>> Building shared library tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/libL1TriggerRPCTrigger.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/MuonsGrabber.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCBasicTrigConfig.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCConeBuilderFromES.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCConst.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCFinalSorter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCHalfSorter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCLogCone.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCLogHit.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCMuon.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPac.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPacBase.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPacData.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPacManager.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPacMuon.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPacTrigger.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCPatternsParser.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCStripsRing.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTBGhostBuster.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTBMuon.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTCGhostBusterSorter.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTriggerBoard.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTriggerConfiguration.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/RPCTriggerCrate.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/TEPatternsGroup.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/TPatternsGroup.cc.o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/TTPatternsGroup.cc.o -o tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/libL1TriggerRPCTrigger.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/biglib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/lib/el8_amd64_gcc10 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/external/el8_amd64_gcc10/lib -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/static/el8_amd64_gcc10 -lGeometryRPCGeometry -lDataFormatsRPCDigi -lCondFormatsDataRecord -lCondFormatsRPCObjects -lGeometryCommonTopologies -lCondFormatsAlignment -lCondFormatsL1TObjects -lDataFormatsGeometryCommonDetAlgo -lGeometryRecords -lCondFormatsAlignmentRecord -lDataFormatsGeometrySurface -lDataFormatsL1GlobalCaloTrigger -lDataFormatsCLHEP -lDataFormatsEcalDetId -lDataFormatsGeometryVector -lDataFormatsL1CaloTrigger -lDataFormatsL1GlobalTrigger -lDataFormatsMuonDetId -lFWCoreFramework -lDataFormatsDetId -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lUtilitiesXerces -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lgsl -luuid -ltbb -lxerces-c -llzma -lz -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/RPCTrigger/src/MuonsGrabber.cc:26:7: warning: type 'struct XStr' violates the C++ One Definition Rule [-Wodr]
    26 | class XStr {
      |       ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/RPCTrigger/src/RPCPatternsParser.cc:66:7: note: a different type is defined in another translation unit
   66 | class XStr {
      |       ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/RPCTrigger/src/MuonsGrabber.cc:35:10: note: the first difference of corresponding definitions is field 'fUnicodeForm'
   35 |   XMLCh* fUnicodeForm;
      |          ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/9802c30fc48bdc09db9c7193cb951860/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_LTO_X_2022-07-07-2300/src/L1Trigger/RPCTrigger/src/RPCPatternsParser.cc:90:10: note: a field with different name is defined in another translation unit
   90 |   XMLCh* m_fUnicodeForm;
      |          ^
Copying tmp/el8_amd64_gcc10/src/L1Trigger/RPCTrigger/src/L1TriggerRPCTrigger/libL1TriggerRPCTrigger.so to productstore area:
Leaving library rule at L1Trigger/RPCTrigger

These warnings are present also in other packages, such as reported in #38650 (It seems there are some elements defined multiple times within the same namespace leading to violation of the C++ One Definition Rule) and #38649 (Signed overflow could occur under certain conditions). Could you please have a look at it?

Many thanks,
Andrea.

[aandvalenzuela]

assign l1

[cmsbuild]

New categories assigned: l1

@epalencia,@rekovic,@cecilecaillol you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @aandvalenzuela Andrea Valenzuela.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[aandvalenzuela]

Hi,

-Wstrict-overflow flag is deprecated and we have dropped it (cms-sw/cmsdist#8026). Therefore, warnings at L1Trigger/CSCTrackFinder and L1Trigger/TrackFindingTracklet are already gone. Nevertheless, the warning at L1Trigger/RPCTrigger reporting -Wodr (violation of the One Definition Rule) should be fixed. Could you please have a look at it?

Many thanks!

[smuzaffar]

@aandvalenzuela closing this issue as #39135 has fixed the ODR warnings from L1Trigger/RPCTrigger package.