Pr90x l1t prescales from payloads #17512

rekovic · 2017-02-14T15:44:51Z

90x PR: Updated L1TGlobalUtil to now also access L1T prescales from payloads, using GlobalTag.

Example:

cmsRun L1Trigger/L1TGlobal/test/runGTSummary.py

rekovic · 2017-02-14T15:44:59Z

please test

cmsbuild · 2017-02-14T15:45:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17787/console Started: 2017/02/14 17:45

cmsbuild · 2017-02-14T15:45:16Z

A new Pull Request was created by @rekovic for CMSSW_9_0_X.

It involves the following packages:

L1Trigger/L1TGlobal
L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Martin-Grunewald · 2017-02-14T17:14:23Z

@rekovic @apana
Can you please move the cout back to MessageLogger?

cmsbuild · 2017-02-14T18:26:18Z

-1

Tested at: e14dbd7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17512/17787/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Feb 14 19:13:31 2017-date Tue Feb 14 19:02:21 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Feb 14 19:13:31 2017-date Tue Feb 14 19:02:21 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Feb 14 19:11:37 2017-date Tue Feb 14 19:02:29 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Tue Feb 14 19:11:37 2017-date Tue Feb 14 19:02:29 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Feb 14 19:18:28 2017-date Tue Feb 14 19:09:23 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Feb 14 19:18:28 2017-date Tue Feb 14 19:09:23 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Feb 14 19:22:15 2017-date Tue Feb 14 19:17:37 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Tue Feb 14 19:22:15 2017-date Tue Feb 14 19:17:37 2017 s - exit: 16640

cmsbuild · 2017-02-14T18:26:20Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

…module after the change in L1TGlobalUtils.

cmsbuild · 2017-02-28T13:23:18Z

Pull request #17512 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2017-02-28T14:06:02Z

@rekovic @apana
Can you please move the cout back to MessageLogger?

apana · 2017-03-01T04:39:15Z

Hi Martin,

Sorry I forgot to followup on this request. I will take care of the cout.

-Len

cmsbuild · 2017-03-01T12:54:52Z

Pull request #17512 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

rekovic · 2017-03-01T12:55:34Z

@Martin-Grunewald, @apana

Can you please move the cout back to MessageLogger?

Done.

dmitrijus · 2017-03-02T08:20:26Z

L1Trigger/L1TGlobal/plugins/L1TGlobalSummary.cc

  minBx_              = iConfig.getParameter<int>("MinBx");
-  maxBx_              = iConfig.getParameter<int>("MaxBx");     
+  maxBx_              = iConfig.getParameter<int>("MaxBx");
  gtUtil_             = new L1TGlobalUtil(iConfig, consumesCollector(), *this, algInputTag_, extInputTag_);


can this become a member? Or at least std::unique_ptr?

dmitrijus · 2017-03-02T08:23:18Z

+1

I did request a small change, but it was there before this PR as well - the PR does not make it worse.

cmsbuild · 2017-03-02T08:23:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18045/console Started: 2017/03/02 09:25
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18123/console Started: 2017/03/03 04:04

cmsbuild · 2017-03-03T04:20:01Z

-1

Tested at: b246965

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17512/18123/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Mar 3 05:13:40 2017-date Fri Mar 3 05:05:19 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Mar 3 05:13:40 2017-date Fri Mar 3 05:05:19 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Mar 3 05:12:23 2017-date Fri Mar 3 05:05:25 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Mar 3 05:12:23 2017-date Fri Mar 3 05:05:25 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Mar 3 05:12:22 2017-date Fri Mar 3 05:05:39 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Mar 3 05:12:22 2017-date Fri Mar 3 05:05:39 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Mar 3 05:13:02 2017-date Fri Mar 3 05:05:52 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Mar 3 05:13:02 2017-date Fri Mar 3 05:05:52 2017 s - exit: 16640

cmsbuild · 2017-03-03T04:20:04Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

fwyzard · 2017-03-15T14:11:06Z

sorry @rekovic @davidlange6 , what happened to this PR ?
has it been integrated somewhere else ?

davidlange6 · 2017-03-16T07:27:10Z

not that i'm aware of (don't recall seeing a version that worked)

rekovic · 2017-03-16T08:04:58Z

@fwyzard @davidlange6 Correct - the new version is being worked on.

apana and others added 4 commits February 14, 2017 15:57

Update to read L1 prescales from dB

f1623b3

cfi for when running uGT emulator

fc489c5

Post conflict cleanup: remove duplicate function declaration.

db513e2

Include header for MessageLogger.

e14dbd7

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 14, 2017

cmsbuild added comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Feb 14, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2017

rekovic mentioned this pull request Feb 14, 2017

Pr80x l1t prescales from payloads #17513

Closed

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 14, 2017

Fix the missing configuration ReadPrescalesFromFile parameter in DQM …

255cf62

…module after the change in L1TGlobalUtils.

cmsbuild added comparison-pending dqm-pending tests-pending and removed comparison-notrun tests-rejected labels Feb 28, 2017

Cout back to LogVerbatim.

b246965

dmitrijus suggested changes Mar 2, 2017

View reviewed changes

cmsbuild added dqm-approved and removed dqm-pending labels Mar 2, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2017

cmsbuild mentioned this pull request Mar 2, 2017

Pr90x l1t prescales from payloads #17721

Closed

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 3, 2017

davidlange6 closed this Mar 13, 2017

rekovic mentioned this pull request Mar 27, 2017

Pr90x l1t prescales from payloads - bis #18101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr90x l1t prescales from payloads #17512

Pr90x l1t prescales from payloads #17512

rekovic commented Feb 14, 2017

rekovic commented Feb 14, 2017

cmsbuild commented Feb 14, 2017 •

edited

cmsbuild commented Feb 14, 2017

Martin-Grunewald commented Feb 14, 2017

cmsbuild commented Feb 14, 2017

cmsbuild commented Feb 14, 2017

cmsbuild commented Feb 28, 2017

Martin-Grunewald commented Feb 28, 2017

apana commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

rekovic commented Mar 1, 2017

dmitrijus Mar 2, 2017

dmitrijus commented Mar 2, 2017

cmsbuild commented Mar 2, 2017 •

edited

cmsbuild commented Mar 3, 2017

cmsbuild commented Mar 3, 2017

fwyzard commented Mar 15, 2017 •

edited

davidlange6 commented Mar 16, 2017

rekovic commented Mar 16, 2017

Pr90x l1t prescales from payloads #17512

Pr90x l1t prescales from payloads #17512

Conversation

rekovic commented Feb 14, 2017

rekovic commented Feb 14, 2017

cmsbuild commented Feb 14, 2017 • edited

cmsbuild commented Feb 14, 2017

Martin-Grunewald commented Feb 14, 2017

cmsbuild commented Feb 14, 2017

cmsbuild commented Feb 14, 2017

cmsbuild commented Feb 28, 2017

Martin-Grunewald commented Feb 28, 2017

apana commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

rekovic commented Mar 1, 2017

dmitrijus Mar 2, 2017

Choose a reason for hiding this comment

dmitrijus commented Mar 2, 2017

cmsbuild commented Mar 2, 2017 • edited

cmsbuild commented Mar 3, 2017

cmsbuild commented Mar 3, 2017

fwyzard commented Mar 15, 2017 • edited

davidlange6 commented Mar 16, 2017

rekovic commented Mar 16, 2017

cmsbuild commented Feb 14, 2017 •

edited

cmsbuild commented Mar 2, 2017 •

edited

fwyzard commented Mar 15, 2017 •

edited