-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr90x l1t prescales from payloads - bis #18101
Pr90x l1t prescales from payloads - bis #18101
Conversation
…module after the change in L1TGlobalUtils.
…riggerProducer configuration file.
A new Pull Request was created by @rekovic for CMSSW_9_0_X. It involves the following packages: DQM/SiStripMonitorClient @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 1cc365e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-26-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Mar 28 03:53:21 2017-date Tue Mar 28 03:49:33 2017 s - exit: 16640 |
Comparison job queued. |
Now all the matrix tests pass! But some of the Add On tests fail. It seems to be the issue with the GlobalTag used, which are set in HLTrigger/Configuration . Here is some more detail. Add Ons fail due to errors: ----- Begin Fatal Exception 28-Mar-2017 04:06:04 CEST----------------------- An exception of category 'NoRecord' occurred while [0] Processing run: 1 [1] Calling global beginRun for module L1TGlobalSummary/'hltL1TGlobalSummary' Exception Message: No "L1TGlobalPrescalesVetosRcd" record found in the EventSetup for synchronization value Run: 1 LuminosityBlock: 0 Event: 0 Time: 1 Please add an ESSource or ESProducer that delivers such a record. ----- End Fatal Exception ------------------------------------------------- Some workflows PASS, and some FAIL, and seem to be differ only by a GlobalTag (eg. run2_mc_Fake1 vs. run2_mc_Fake2)
@Martin-Grunewald can you comment? |
The GTs used in addON HLT tests are defined here: I would assume the corresponding base GTs still miss the L1T record. GRun and Fake2 are stage-2 L1T, but Fake1 is for stage-1 L1T. Are all of those supposed to use the new record? |
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
…lDescription() method.
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
…e by hand made l1tGlobalSummary_cfi.py.
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
…should reproduce all results with reference IB release.
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
Vladimir,
if the purpose is only to test, I would suggest to leave the default to
false, and make the change only in the relevant python file.
.A
…On 7 April 2017 at 14:58, cmsbuild ***@***.***> wrote:
Pull request #18101 <#18101> was
updated. @perrotta <https://github.com/perrotta>, @monttj
<https://github.com/monttj>, @dmitrijus <https://github.com/dmitrijus>,
@cmsbuild <https://github.com/cmsbuild>, @rekovic
<https://github.com/rekovic>, @slava77 <https://github.com/slava77>,
@vanbesien <https://github.com/vanbesien>, @mulhearn
<https://github.com/mulhearn>, @davidlange6
<https://github.com/davidlange6> can you please check and sign again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18101 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD4ZoQP08HRqhEwS0s9shPNzS7nBlS3Xks5rtjMTgaJpZM4Mqy6X>
.
--
Strategy is a system of expedients.
Generalfeldmarschall Helmuth Karl Bernhard Graf von Moltke
|
Pull request #18101 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 7181056 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_X_2017-04-16-0000/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Apr 17 20:38:52 2017-date Mon Apr 17 20:33:19 2017 s - exit: 16640 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Any update on this PR? |
Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking) |
90x PR: Updated L1TGlobalUtil to now also access L1T prescales from payloads, using GlobalTag.
Replace #17512, and backport of #17721
Example: