Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

christopheralanwest · 2019-08-05T20:27:09Z

PR description:

This is a backport of PR #27683. With this PR, 2018 collision GTs are up-to-date with the corresponding 11_0_X GTs:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_2017_2018_Candidate_2019_08_03_03_51_45/106X_dataRun2_2017_2018_Candidate_2019_08_05_17_19_13
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_Candidate_2019_08_03_03_55_32/106X_dataRun2_relval_Candidate_2019_08_05_17_36_16
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HEfail_Candidate_2019_08_02_16_55_52/106X_dataRun2_PromptLike_HEfail_Candidate_2019_08_05_17_40_11
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_Candidate_2019_08_02_16_53_14/106X_dataRun2_PromptLike_Candidate_2019_08_05_17_44_43
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HI_Candidate_2019_08_02_16_55_18/106X_dataRun2_PromptLike_HI_Candidate_2019_08_05_17_49_31
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_Candidate_2019_08_03_11_37_17/106X_upgrade2018_realistic_Candidate_2019_08_05_17_57_55
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_Candidate_2019_08_03_11_39_50/106X_upgrade2018_realistic_HEfail_Candidate_2019_08_05_18_03_46

The GT diffs with respect to the current 10_6_X autoCond are:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_2017_2018_Candidate_2019_08_05_17_19_13/106X_dataRun2_v17
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_Candidate_2019_08_05_17_36_16/106X_dataRun2_relval_v16
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HEfail_Candidate_2019_08_05_17_40_11/106X_dataRun2_PromptLike_HEfail_v9
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_Candidate_2019_08_05_17_44_43/106X_dataRun2_PromptLike_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HI_Candidate_2019_08_05_17_49_31/106X_dataRun2_PromptLike_HI_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_Candidate_2019_08_05_17_57_55/106X_upgrade2018_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HEfail_Candidate_2019_08_05_18_03_46/106X_upgrade2018_realistic_HEfail_v6

This PR should be merged after #27605 so that clean PR comparison tests can be run on this PR. The merge conflict with #27605 will be resolved by preferring the changes in this PR. The backport of PR #27644 will also conflict this PR. Once either this PR or the backport of #27644 are merged, the GT candidates in the other PR will be converted to versioned GTs.

PR validation:

Validation as in PR #27683.

if this PR is a backport please specify the original PR:

Backport of #27683

christopheralanwest · 2019-08-05T20:27:27Z

backport #27683

cmsbuild · 2019-08-05T20:27:37Z

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL #27683

christopheralanwest · 2019-08-05T20:37:12Z

please test

cmsbuild · 2019-08-05T20:37:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1842/console Started: 2019/08/05 22:38

cmsbuild · 2019-08-05T22:37:26Z

+1
Tested at: 7f00cb3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1842/summary.html

cmsbuild · 2019-08-05T22:37:30Z

Comparison job queued.

cmsbuild · 2019-08-06T02:28:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1842/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 11513 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3208248
DQMHistoTests: Total failures: 11451
DQMHistoTests: Total nulls: 15
DQMHistoTests: Total successes: 3196448
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.051 KiB( 32 files compared)
DQMHistoSizes: changed ( 4.53 ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.731 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.85 ): -0.031 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

christopheralanwest · 2019-08-06T11:29:45Z

The number of differences in the PR comparison tests for pre-2017 data workflows are the same as in PR #27605 so most likely this PR only affects 2018 data and MC.

cmsbuild · 2019-08-06T21:23:42Z

Pull request #27698 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

cmsbuild · 2019-08-07T00:15:37Z

+1
Tested at: f702bcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1860/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix energy fractions after jet resolution smearing [106X backport] #27506 @ahinzmann: Fix energy fractions after jet resolution smearing [106X backport]
PPS: update of association cuts (backport of #27440) #27475 @CTPPS: PPS: update of association cuts (backport of PPS: update of association cuts #27440)
Pr ultra legacy ps weigts #27496 @Andrej-CMS: Pr ultra legacy ps weigts
New plots for Tracking Workspace (Backport to CMSSW_10_6_X of #27330) #27435 @hbecerri: New plots for Tracking Workspace (Backport to CMSSW_10_6_X of New plots for Tracking Workspace #27330)
Validation fixes - 10_6_X #27224 @perrotta: Validation fixes - 10_6_X
Update ECAL conditions to provide correct reference for 2016 and 2018 UL [10_6_X] #27605 @christopheralanwest: Update ECAL conditions to provide correct reference for 2016 and 2018 UL [10_6_X]
[Backport] DQMGEMStatusDigi bug fix #27487 @hyunyong: [Backport] DQMGEMStatusDigi bug fix

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1860/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1860/git-merge-result

cmsbuild · 2019-08-07T00:15:41Z

Comparison job queued.

cmsbuild · 2019-08-07T03:50:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1860/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 11611 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3208248
DQMHistoTests: Total failures: 11469
DQMHistoTests: Total nulls: 15
DQMHistoTests: Total successes: 3196430
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3206.914 KiB( 32 files compared)
DQMHistoSizes: changed ( 10224.0,... ): 132.521 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 140.56,... ): 166.837 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 4.22,... ): 60.878 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 25202.0,... ): 132.131 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 136.731 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 29034.0,... ): 133.693 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.85 ): -0.031 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 7.3 ): 60.995 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 4.53 ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 140.53 ): ...
Checked 137 log files, 14 edm output root files, 33 DQM output files

christopheralanwest · 2019-08-07T12:46:38Z

please test

The tests are being run on the new IB to cross-check that there are no changes to pre-2018 workflows.

cmsbuild · 2019-08-07T12:47:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1865/console Started: 2019/08/07 14:49

cmsbuild · 2019-08-07T14:42:45Z

+1
Tested at: f702bcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1865/summary.html

cmsbuild · 2019-08-07T14:42:49Z

Comparison job queued.

cmsbuild · 2019-08-07T17:55:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ca14/1865/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6040 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211049
DQMHistoTests: Total failures: 10793
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 3199915
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.031 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.85 ): -0.031 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

christopheralanwest · 2019-08-07T19:07:13Z

Changes are only seen in 2018 workflows: 136.85, 10824.0 and 250202.181. I would like to turn the candidate GTs into versioned GT but I will wait until the HCAL negative energy filter issue is resolved before deciding on the GT version numbering. auto:run2_data may change to 106X_dataRun2_v19 or 106X_dataRun2_v20 in the upcoming commit but I don't know which numbering would be most logical yet.

kpedro88 · 2019-08-27T16:01:10Z

@christopheralanwest just confirming that this can be closed because it's included in #27816

christopheralanwest · 2019-08-27T16:12:09Z

Closing this PR because the relevant conditions are included in #27816.

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL

7f00cb3

cmsbuild added this to the CMSSW_10_6_X milestone Aug 5, 2019

cmsbuild added alca-pending backport-ok comparison-pending orp-pending pending-signatures tests-pending labels Aug 5, 2019

christopheralanwest changed the title ~~Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL~~ Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] Aug 5, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 5, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 6, 2019

christopheralanwest mentioned this pull request Aug 6, 2019

Update ECAL conditions to provide correct reference for 2016 and 2018 UL [10_6_X] #27605

Merged

Merge branch 'CMSSW_10_6_X' into alca-2018UL-gt-106X

f702bcf

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 6, 2019

cmsbuild added the tests-started label Aug 6, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 7, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 7, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 7, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 7, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 7, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 7, 2019

This was referenced Aug 16, 2019

Use another PR in baseline for comparison tests cms-sw/cms-bot#1188

Open

Bug fix for 2016-2017 HBHE negative energy filter [10_6_X] #27734

Merged

enabling UL regression for 2018 (and likely Run3) : 106X #27816

Merged

christopheralanwest closed this Aug 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

christopheralanwest commented Aug 5, 2019

christopheralanwest commented Aug 5, 2019

cmsbuild commented Aug 5, 2019 •

edited

Loading

christopheralanwest commented Aug 5, 2019

cmsbuild commented Aug 5, 2019 •

edited

Loading

cmsbuild commented Aug 5, 2019

cmsbuild commented Aug 5, 2019

cmsbuild commented Aug 6, 2019

christopheralanwest commented Aug 6, 2019

cmsbuild commented Aug 6, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

christopheralanwest commented Aug 7, 2019

cmsbuild commented Aug 7, 2019 •

edited

Loading

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

christopheralanwest commented Aug 7, 2019

kpedro88 commented Aug 27, 2019

christopheralanwest commented Aug 27, 2019

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

Conversation

christopheralanwest commented Aug 5, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

christopheralanwest commented Aug 5, 2019

cmsbuild commented Aug 5, 2019 • edited Loading

christopheralanwest commented Aug 5, 2019

cmsbuild commented Aug 5, 2019 • edited Loading

cmsbuild commented Aug 5, 2019

cmsbuild commented Aug 5, 2019

cmsbuild commented Aug 6, 2019

christopheralanwest commented Aug 6, 2019

cmsbuild commented Aug 6, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

christopheralanwest commented Aug 7, 2019

cmsbuild commented Aug 7, 2019 • edited Loading

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

cmsbuild commented Aug 7, 2019

christopheralanwest commented Aug 7, 2019

kpedro88 commented Aug 27, 2019

christopheralanwest commented Aug 27, 2019

cmsbuild commented Aug 5, 2019 •

edited

Loading

cmsbuild commented Aug 5, 2019 •

edited

Loading

cmsbuild commented Aug 7, 2019 •

edited

Loading