-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698
Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698
Conversation
backport #27683 |
A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The number of differences in the PR comparison tests for pre-2017 data workflows are the same as in PR #27605 so most likely this PR only affects 2018 data and MC. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test The tests are being run on the new IB to cross-check that there are no changes to pre-2018 workflows. |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Changes are only seen in 2018 workflows: 136.85, 10824.0 and 250202.181. I would like to turn the candidate GTs into versioned GT but I will wait until the HCAL negative energy filter issue is resolved before deciding on the GT version numbering. |
@christopheralanwest just confirming that this can be closed because it's included in #27816 |
Closing this PR because the relevant conditions are included in #27816. |
PR description:
This is a backport of PR #27683. With this PR, 2018 collision GTs are up-to-date with the corresponding 11_0_X GTs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_2017_2018_Candidate_2019_08_03_03_51_45/106X_dataRun2_2017_2018_Candidate_2019_08_05_17_19_13
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_Candidate_2019_08_03_03_55_32/106X_dataRun2_relval_Candidate_2019_08_05_17_36_16
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HEfail_Candidate_2019_08_02_16_55_52/106X_dataRun2_PromptLike_HEfail_Candidate_2019_08_05_17_40_11
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_Candidate_2019_08_02_16_53_14/106X_dataRun2_PromptLike_Candidate_2019_08_05_17_44_43
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HI_Candidate_2019_08_02_16_55_18/106X_dataRun2_PromptLike_HI_Candidate_2019_08_05_17_49_31
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_Candidate_2019_08_03_11_37_17/106X_upgrade2018_realistic_Candidate_2019_08_05_17_57_55
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_Candidate_2019_08_03_11_39_50/106X_upgrade2018_realistic_HEfail_Candidate_2019_08_05_18_03_46
The GT diffs with respect to the current 10_6_X autoCond are:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_2017_2018_Candidate_2019_08_05_17_19_13/106X_dataRun2_v17
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_Candidate_2019_08_05_17_36_16/106X_dataRun2_relval_v16
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HEfail_Candidate_2019_08_05_17_40_11/106X_dataRun2_PromptLike_HEfail_v9
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_Candidate_2019_08_05_17_44_43/106X_dataRun2_PromptLike_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HI_Candidate_2019_08_05_17_49_31/106X_dataRun2_PromptLike_HI_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_Candidate_2019_08_05_17_57_55/106X_upgrade2018_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HEfail_Candidate_2019_08_05_18_03_46/106X_upgrade2018_realistic_HEfail_v6
This PR should be merged after #27605 so that clean PR comparison tests can be run on this PR. The merge conflict with #27605 will be resolved by preferring the changes in this PR. The backport of PR #27644 will also conflict this PR. Once either this PR or the backport of #27644 are merged, the GT candidates in the other PR will be converted to versioned GTs.
PR validation:
Validation as in PR #27683.
if this PR is a backport please specify the original PR:
Backport of #27683