-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for HCAL online TPG LUT and Trigger keys #28930
Conversation
…enerated in advance
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28930/13732
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28930/13733
|
A new Pull Request was created by @ak427 for master. It involves the following packages: CalibCalorimetry/HcalTPGAlgos @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
Pull request #28930 was updated. @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The PR includes updates for online HCAL LUT and trigger key generation. It should not affect any offline processing. Main changes include:
PR validation:
The code has been used to generate past and upcoming online LUTs and trigger keys.
The PR should not affect any offline workflow.