Clean up BuildFiles under RecoLocalTracker/ #29705

fwyzard · 2020-05-05T12:50:10Z

Clean up BuildFile.xml filea with xmllint --format.

fwyzard · 2020-05-05T12:50:12Z

@cmsbuild, please test

cmsbuild · 2020-05-05T12:50:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-05T13:36:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29705/15105

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelClusterizer/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-05-05T13:36:57Z

The tests are being triggered in jenkins.

cmsbuild · 2020-05-05T13:36:58Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

RecoLocalTracker/ClusterParameterEstimator
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/Records
RecoLocalTracker/SiPhase2Clusterizer
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripRecHitConverter
RecoLocalTracker/SiStripZeroSuppression
RecoLocalTracker/SubCollectionProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @makortel, @robervalwalsh, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @dkotlins, @felicepantaleo, @gpetruc, @ebrondol, @threus, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-05-05T17:25:40Z

The code-checks are being triggered in jenkins.

Clean up BuildFile.xml filea with `xmllint --format`.

cmsbuild · 2020-05-05T17:26:02Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-05-05T17:26:18Z

@cmsbuild, please test

cmsbuild · 2020-05-05T17:30:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29705/15161

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelClusterizer/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-05-05T17:30:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6074/console Started: 2020/05/05 19:39

cmsbuild · 2020-05-05T17:30:57Z

Pull request #29705 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

cmsbuild · 2020-05-05T20:58:10Z

+1
Tested at: b1cf708
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af796e/6074/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean up BuildFiles under AnalysisDataFormats/ #29643 @fwyzard: Clean up BuildFiles under AnalysisDataFormats/
[LLVM10] Calibration fix clang warnings #29594 @mrodozov: [LLVM10] Calibration fix clang warnings
Clean up BuildFiles under Alignment/ #29641 @fwyzard: Clean up BuildFiles under Alignment/
Clean up BuildFiles under CalibFormats/ #29645 @fwyzard: Clean up BuildFiles under CalibFormats/
Add Run 3 beam pipe + Minor update of Phase 2 beam pipe #29589 @ghugo83: Add Run 3 beam pipe + Minor update of Phase 2 beam pipe
MTD geometry: porting of MTDTopology to DD4hep #29599 @fabiocos: MTD geometry: porting of MTDTopology to DD4hep
Add Phase 2 Outer Tracker with sensors updates + OTST MB update. Remove T18. #29607 @ghugo83: Add Phase 2 Outer Tracker with sensors updates + OTST MB update. Remove T18.
Add warning if WF name will be too long for submission #29621 @srimanob: Add warning if WF name will be too long for submission
Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation
Update offline GTs for Run 1 and Run 2 data, including special runs. #29629 @christopheralanwest: Update offline GTs for Run 1 and Run 2 data, including special runs.
Avoid uninitialized data warnings in PtAssignmentEngine2017 #29519 @Dr15Jones: Avoid uninitialized data warnings in PtAssignmentEngine2017
Clean up BuildFiles under AnalysisAlgos/ #29642 @fwyzard: Clean up BuildFiles under AnalysisAlgos/
Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
Clean up BuildFiles under HeterogeneousCore/ #29638 @fwyzard: Clean up BuildFiles under HeterogeneousCore/
decrease event size by storing PFCandidates with half precision float… #29513 @jsalfeld: decrease event size by storing PFCandidates with half precision float
Clean up BuildFiles under HLTrigger/ #29636 @fwyzard: Clean up BuildFiles under HLTrigger/

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af796e/6074/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af796e/6074/git-merge-result

cmsbuild · 2020-05-05T20:58:13Z

Comparison job queued.

cmsbuild · 2020-05-06T05:06:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af796e/6074/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695919
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2020-05-06T09:38:56Z

+1

Technical
Changes are only in white spaces and empty lines
Jenkins tests pass
(Trying to clean up the queue of pendig pull requests for reconstruction)
"DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates" due to testing this together with Added particle flow candidates to particle flow validation #29628

silviodonato · 2020-05-06T12:40:23Z

RecoLocalTracker/SiPixelRecHits/test/BuildFile.xml

@@ -1,26 +1,20 @@
-<use name="rootmath"/> 


@fwyzard was it expected? The order is changing

I sorted them, since I had to fix this BuildFile by hand

silviodonato · 2020-05-06T13:08:13Z

merge

cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

fwyzard force-pushed the branch_lintBuildFile_RecoLocalTracker branch from 5ca1ddb to ad84f29 Compare May 5, 2020 17:25

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels May 5, 2020

Clean up BuildFiles under RecoLocalTracker/

b1cf708

Clean up BuildFile.xml filea with `xmllint --format`.

fwyzard force-pushed the branch_lintBuildFile_RecoLocalTracker branch from ad84f29 to b1cf708 Compare May 5, 2020 17:25

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

cmsbuild added tests-approved and removed tests-started labels May 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 6, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 6, 2020

silviodonato reviewed May 6, 2020

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 6, 2020

cmsbuild merged commit 112ddb0 into cms-sw:master May 6, 2020

cmsbuild mentioned this pull request May 6, 2020

Revert "PUPPI MET in RECO" #29748

Merged

fwyzard deleted the branch_lintBuildFile_RecoLocalTracker branch May 8, 2020 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up BuildFiles under RecoLocalTracker/ #29705

Clean up BuildFiles under RecoLocalTracker/ #29705

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

perrotta commented May 6, 2020

silviodonato May 6, 2020

fwyzard May 6, 2020

silviodonato commented May 6, 2020

Clean up BuildFiles under RecoLocalTracker/ #29705

Clean up BuildFiles under RecoLocalTracker/ #29705

Conversation

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

perrotta commented May 6, 2020

silviodonato May 6, 2020

Choose a reason for hiding this comment

fwyzard May 6, 2020

Choose a reason for hiding this comment

silviodonato commented May 6, 2020

cmsbuild commented May 5, 2020 •

edited