Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles in and after Reco area #30679

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Clean BuildFiles in and after Reco area #30679

merged 2 commits into from
Jul 21, 2020

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jul 14, 2020

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30535), this time covering all uses in the plugins which are not directly in the root of the BuildFile. My script did not catch these before.

Review comment #30535 (comment) from previous PR has been addressed.

As always, only the dependencies which are not included in any of the plugin sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included in the libraries.

Edit: In the second commit, some additional includes cleanup in RecoEgamma was done.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30679/16967

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQM/BeamMonitor
RecoLocalTracker/SiStripClusterizer
RecoTracker/TkSeedGenerator
RecoVertex/BeamSpotProducer
SLHCUpgradeSimulations/Geometry
SimCalorimetry/CastorSim
SimCalorimetry/EcalSelectiveReadoutAlgos
SimCalorimetry/EcalSimAlgos
SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/GeneratorProducts
SimG4Core/Application
SimG4Core/DD4hepGeometry
SimGeneral/HepPDTRecord
SimGeneral/NoiseGenerators
SimGeneral/TrackingAnalysis
SimMuon/CSCDigitizer
SimMuon/DTDigitizer
SimMuon/MCTruth
SimMuon/RPCDigitizer
SimTracker/TrackTriggerAssociation
SimTransport/PPSProtonTransport
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopJetCombination
TrackingTools/DetLayers
TrackingTools/TrajectoryFiltering
TrackingTools/TransientTrack
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonHits
Validation/RecoMuon
Validation/RecoParticleFlow

@SiewYan, @andrius-k, @schneiml, @ianna, @kpedro88, @rekovic, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @jpata, @qliphy, @benkrikler, @mkirsano, @kmaeshima, @christopheralanwest can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @argiro, @jshlee, @alesaggio, @threus, @mmusich, @cericeci, @battibass, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @HuguesBrun, @slomeo, @dildick, @pieterdavid, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @hatakeyamak, @mschrode, @ebrondol, @ptcox, @mtosi, @fabiocos, @rchatter, @trocino, @gbenelli, @Fedespring, @calderona, @lecriste, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 14, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: b966a8b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2253a/7931/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2253a/7931/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787378
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2020

@guitargeek
please add a note at least in the PR description that some code was also cleaned up (before rebase it was just one or two lines.
Now, there was a scope creep and about 100 lines were edited in about 20 files in RecoEgamma (which wasn't even touched before the rebase)

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2020

+1

for #30679 3ae9466

  • technical updates: code changes are in line with the PR description and the follow up review , plus some additional cleanup in RecoEgamma
  • jenkins tests pass and comparisons with the baseline show no differences

@qliphy
Copy link
Contributor

qliphy commented Jul 17, 2020

+1

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Jul 17, 2020

+1

@pohsun
Copy link

pohsun commented Jul 18, 2020

+1

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Jul 20, 2020

l1 signature is still missing
it would be nice to sign it

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment