Clean BuildFiles in and after Reco area

[guitargeek]

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30535), this time covering all uses in the plugins which are not directly in the root of the BuildFile. My script did not catch these before.

Review comment #30535 (comment) from previous PR has been addressed.

As always, only the dependencies which are not included in any of the plugin sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included in the libraries.

Edit: In the second commit, some additional includes cleanup in RecoEgamma was done.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30679/16967

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoVertex/BeamSpotProducer/plugins/BuildFile.xml modified in PR(s): BS online for 11 2 x #30591, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQM/BeamMonitor
RecoLocalTracker/SiStripClusterizer
RecoTracker/TkSeedGenerator
RecoVertex/BeamSpotProducer
SLHCUpgradeSimulations/Geometry
SimCalorimetry/CastorSim
SimCalorimetry/EcalSelectiveReadoutAlgos
SimCalorimetry/EcalSimAlgos
SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/GeneratorProducts
SimG4Core/Application
SimG4Core/DD4hepGeometry
SimGeneral/HepPDTRecord
SimGeneral/NoiseGenerators
SimGeneral/TrackingAnalysis
SimMuon/CSCDigitizer
SimMuon/DTDigitizer
SimMuon/MCTruth
SimMuon/RPCDigitizer
SimTracker/TrackTriggerAssociation
SimTransport/PPSProtonTransport
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopJetCombination
TrackingTools/DetLayers
TrackingTools/TrajectoryFiltering
TrackingTools/TransientTrack
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonHits
Validation/RecoMuon
Validation/RecoParticleFlow

@SiewYan, @andrius-k, @schneiml, @ianna, @kpedro88, @rekovic, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @jpata, @qliphy, @benkrikler, @mkirsano, @kmaeshima, @christopheralanwest can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @argiro, @jshlee, @alesaggio, @threus, @mmusich, @cericeci, @battibass, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @HuguesBrun, @slomeo, @dildick, @pieterdavid, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @hatakeyamak, @mschrode, @ebrondol, @ptcox, @mtosi, @fabiocos, @rchatter, @trocino, @gbenelli, @Fedespring, @calderona, @lecriste, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-14-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7931/console Started: 2020/07/14 17:12

[cmsbuild]

+1
Tested at: b966a8b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2253a/7931/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2253a/7931/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787429
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787378
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[slava77]

@guitargeek
please add a note at least in the PR description that some code was also cleaned up (before rebase it was just one or two lines.
Now, there was a scope creep and about 100 lines were edited in about 20 files in RecoEgamma (which wasn't even touched before the rebase)

[slava77]

+1

for #30679 3ae9466

• technical updates: code changes are in line with the PR description and the follow up review , plus some additional cleanup in RecoEgamma
• jenkins tests pass and comparisons with the baseline show no differences

[qliphy]

+1

[jfernan2]

+1

[civanch]

+1

[pohsun]

+1

[santocch]

+1

[slava77]

l1 signature is still missing
it would be nice to sign it

[silviodonato]

merge