Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 3 instead of 4 OMTF track sub-address as expected by uGMT #45030

Merged
merged 1 commit into from
May 28, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 23, 2024

PR description:

As title says: this PR reduces number of OMTF track sub-addresses sent to uGMT from 4 to 3 to meet expected number. It calms "OMTF muon track address map contains 4 instead of the expected 3 subaddresses. Check the data format. Setting track address to 0." warning without impact on performance as the sub-addresses are currently not used.

PR validation:

tested with wf 141.044

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be potentially backported to 14_0_X to calm warning in uGMT emulator.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45030/40321

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • L1Trigger/L1TMuonOverlapPhase1 (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@dinyar, @eyigitba, @Martin-Grunewald, @JanFSchulte, @thomreis, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef2244/39495/summary.html
COMMIT: b215850
CMSSW: CMSSW_14_1_X_2024-05-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45030/39495/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

type bug-fix

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants