[CPP20] remove depracated use of volatile as for #45072

[VinInn]

in DataFormats/Math/tests
no production code affected.

[VinInn]

@cmsbuild please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45091/40411

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @VinInn for master.

It involves the following packages:

• DataFormats/Math (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @rovere, @missirol, @felicepantaleo, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

related to #45072

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2723b8/39601/summary.html
COMMIT: e00aadf
CMSSW: CMSSW_14_1_X_2024-05-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45091/39601/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338839
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2723b8/39610/summary.html
COMMIT: e00aadf
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45091/39610/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mbluj [DBG] Fix undefined ref errors in L1TMuonOverlapPhase2 #44984
• @abdoulline HcalZDCDetId fix for Run3 #45033
• @mbluj Set 3 instead of 4 OMTF track sub-address as expected by uGMT #45030
• @bsunanda Phase2-hgx356 Fix the bugs in HGCal TB simulation for 2023 scenarios #45036
• @cms-sw clang-tidy: Remove deprecated AnalyzeTemporaryDtors option #45034
• @stahlleiton Add new dEdx calibration condition format #45024
• @iarspider Fix undeclared identifiers in RectangularPixelPhase2Topology #45038
• @bsunanda Run3-alca247A Bug fix to the code Calibration/HcalCalibAlgos/plugins/HcalIsoTrkAnalyzer.cc for initialiting uncorrection of RecHit energies #45046
• @bsunanda Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044
• @bsunanda Run3-alca247YX Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs (restore the material from #45010) #45045

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2723b8/39610/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2723b8/39610/git-merge-result

Comparison Summary

Summary:

• You potentially added 2568 lines to the logs
• Reco comparison results: 128 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 965
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337877
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1